New issue
Advanced search Search tips

Issue 898209 link

Starred by 1 user

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

SetFontFeatures and UpdateTypesettingFeatures disagree on kerning default setting.

Project Member Reported by bunge...@chromium.org, Oct 23

Issue description

SetFontFeatures sets or disables kerning based on GetKerning() which default to on, but UpdateTypesettingFeatures defaults the kerning field in typesetting_features_ to off. The result is that the layout code appears to believe kerning is off by default, but then the shaper turns it off by default.

At the very least SetFontFeatures and UpdateTypesettingFeatures should agree on this value. Even better would be for them to both use the same source of truth.

This is the kerning version of issue 893330. Issue 893330 is similar but with regard to ligatures.
 
Changing the kerning default for UpdateTypesettingFeatures is straight forward, but will require rebaselining.
Cc: e...@chromium.org
Status: Available (was: Untriaged)

Sign in to add a comment