New issue
Advanced search Search tips

Issue 898184 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Oct 29
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

browser_tests failing on chromium.mac/Mac10.13 Tests (dbg)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Oct 23 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of yigu@chromium.org

browser_tests failing on chromium.mac/Mac10.13 Tests (dbg)

Builders failed on: 
- Mac10.13 Tests (dbg): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29

Comment 1 by yigu@chromium.org, Oct 23

Cc: -yigu@chromium.org
Owner: calamity@chromium.org
Status: Assigned (was: Available)
The test SystemWebAppManagerIntegrationTest.WithManifes has been failing mac since it gets landed. PTAL. Thanks!
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=SystemWebAppManagerIntegrationTest.WithManifes
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2a3ef6c2798e9e5708719d703dc5bd4a144feac

commit b2a3ef6c2798e9e5708719d703dc5bd4a144feac
Author: Yi Gu <yigu@chromium.org>
Date: Tue Oct 23 15:38:47 2018

Disable failing test on Mac

The test SystemWebAppManagerIntegrationTest, WithManifest keeps failing
on Mac. Disable it and assign the bug to the owner who added the test
recently.

TBR=calamity@chromium.org
NOTRY=true

Bug:  898184 
Change-Id: I570a0e962a3d37fe6938c0171c30e62f76a9cd4b
Reviewed-on: https://chromium-review.googlesource.com/c/1296810
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601962}
[modify] https://crrev.com/b2a3ef6c2798e9e5708719d703dc5bd4a144feac/chrome/browser/web_applications/bookmark_apps/system_web_app_manager_browsertest.cc

Comment 3 by bsep@chromium.org, Oct 23

Labels: -Sheriff-Chromium
Looks like this was disabled already; removing from sheriff queue.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbf97e46062536d8521693464f1fbff42e506337

commit fbf97e46062536d8521693464f1fbff42e506337
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Oct 29 01:38:26 2018

[System PWAs] Fix SystemWebAppManagerIntegrationTest.WithManifest.

Bug:  898184 
Change-Id: I714c83bcac42c096b70ae281f5441f53bd41eb13
Reviewed-on: https://chromium-review.googlesource.com/c/1297216
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603398}
[modify] https://crrev.com/fbf97e46062536d8521693464f1fbff42e506337/chrome/browser/web_applications/bookmark_apps/system_web_app_manager_browsertest.cc

Comment 5 by calamity@chromium.org, Oct 29

Status: Fixed (was: Assigned)
►

Sign in to add a comment