New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 898180 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Create Sync MemoryDumpProvider

Project Member Reported by erikc...@chromium.org, Oct 23

Issue description

Previous to USS, there was a Sync MemoryDumpProvider. This provided valuable insight into memory issues in the wild for memlog [heap profiling in the wild]. With USS, we appear to have lost all information from the Sync MDP [e.g. # of bookmarks, total memory used by Sync, etc.]. 
 
Cc: mastiz@chromium.org
Labels: Sync-Triaged OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Available (was: Untriaged)
Part of this is that with USS, Sync uses *much* less memory of its own :)
It would still be nice to count it, especially for pseudo-USS data types.

Here's where we do it for directory (i.e. pre-USS) data types:
https://cs.chromium.org/chromium/src/components/sync/engine_impl/sync_manager_impl.cc?rcl=cac0db13cfc9e321cf40231653c9242731eb247a&l=990
And to provide some more context -- we regularly get reports from the field of sync-related components using a lot of memory. e.g. in https://memlog.corp.google.com/report?reportid=fd0fd79bbf07a39a we see that there are ~600,000 bookmarks using 182MB of memory. The Sync MDP allows us to verify that this memory usage is intentional and WAI and not a potential memory leak.
Labels: sync-fixit-2018q4

Sign in to add a comment