Flaky test: PictureInPicturePixelComparisonBrowserTest.VideoPlay Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/16124 Test output log: https://chromium-swarm.appspot.com/task?id=40b96da20bd4ea10 Culprit (100.0% confidence): r601879 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy0wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKcAWNocm9taXVtLm1hYy9NYWMxMC4xMiBUZXN0cy8xNjEyNC9icm93c2VyX3Rlc3RzIG9uIChub25lKSBHUFUgb24gTWFjIG9uIE1hYy0xMC4xMi42L1VHbGpkSFZ5WlVsdVVHbGpkSFZ5WlZCcGVHVnNRMjl0Y0dGeWFYTnZia0p5YjNkelpYSlVaWE4wTGxacFpHVnZVR3hoZVE9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20PictureInPicturePixelComparisonBrowserTest.VideoPlay&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy0wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKcAWNocm9taXVtLm1hYy9NYWMxMC4xMiBUZXN0cy8xNjEyNC9icm93c2VyX3Rlc3RzIG9uIChub25lKSBHUFUgb24gTWFjIG9uIE1hYy0xMC4xMi42L1VHbGpkSFZ5WlVsdVVHbGpkSFZ5WlZCcGVHVnNRMjl0Y0dGeWFYTnZia0p5YjNkelpYSlVaWE4wTGxacFpHVnZVR3hoZVE9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cb39426c8183cdd94719a9b6d47aac1a6d0761a commit 7cb39426c8183cdd94719a9b6d47aac1a6d0761a Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Tue Oct 23 12:09:03 2018 Revert "Enable the pixel by pixel comparison test for Mac OS." This reverts commit 01ccf727764c515153478d2bb340f068874d66d5. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 601879 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDFjY2Y3Mjc3NjRjNTE1MTUzNDc4ZDJiYjM0MGYwNjg4NzRkNjZkNQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/16124 Sample Failed Step: browser_tests on (none) GPU on Mac on Mac-10.12.6 Sample Flaky Test: PictureInPicturePixelComparisonBrowserTest.VideoPlay Original change's description: > Enable the pixel by pixel comparison test for Mac OS. > > 1. Tested on Mac and verify everything works as expected. > 2. Removed the unnecessary call of GetNativeWindow(). > > Change-Id: I377e6bfb004548887b9623b0094da91fa36b4d1c > Reviewed-on: https://chromium-review.googlesource.com/c/1279301 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601879} Change-Id: I54c6f61e3cb1f6bbd0997ccc1e8d616c9977d21d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898146 Reviewed-on: https://chromium-review.googlesource.com/c/1296312 Cr-Commit-Position: refs/heads/master@{#601907} [modify] https://crrev.com/7cb39426c8183cdd94719a9b6d47aac1a6d0761a/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
No more flaky after the revert.
Comment 1 by bugdroid1@chromium.org
, Oct 23