One-pager: https://docs.google.com/document/d/1Tb45cU2WKHPNoCGV4FDbFBgY6z_SUvs7cxmBTBznmD0
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27cb7d86f76ea1382d636d9a070e405f842dd6bd commit 27cb7d86f76ea1382d636d9a070e405f842dd6bd Author: Uladzimir Miniailau <miniailau@google.com> Date: Thu Nov 22 18:01:10 2018 Move public methods of RenderFrameObserver to public section of PasswordAutofillAgent See an explanation at https://chromium-review.googlesource.com/c/chromium/src/+/1306497/6/chrome/renderer/autofill/password_autofill_agent_browsertest.cc#3682. Short version of the explanation: it's a bad practice to use public inheritance and put public methods of the base class to the private section of the derived class. Bug: 898109 Change-Id: Ie9ceed5e860593490ec39788c6a0c353bfdd6947 Reviewed-on: https://chromium-review.googlesource.com/c/1347361 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Cr-Commit-Position: refs/heads/master@{#610460} [modify] https://crrev.com/27cb7d86f76ea1382d636d9a070e405f842dd6bd/components/autofill/content/renderer/password_autofill_agent.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f654a8f551abcb77344787c77c8d4990b3eaeac8 commit f654a8f551abcb77344787c77c8d4990b3eaeac8 Author: Uladzimir Miniailau <miniailau@google.com> Date: Wed Nov 28 16:09:46 2018 Add a cache for autofilled elements. It's useful because: - We don't do unnecessary calls to the browser process. - We can restore elements which were changed by JS. It's an implementation of the first step from the one-pager Bug: 898109 Change-Id: I9caf5bce5e94981b7bd809db2c8ec7a3ec0f0e0e Reviewed-on: https://chromium-review.googlesource.com/c/1306497 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Cr-Commit-Position: refs/heads/master@{#611712} [modify] https://crrev.com/f654a8f551abcb77344787c77c8d4990b3eaeac8/chrome/renderer/autofill/password_autofill_agent_browsertest.cc [modify] https://crrev.com/f654a8f551abcb77344787c77c8d4990b3eaeac8/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/f654a8f551abcb77344787c77c8d4990b3eaeac8/components/autofill/content/renderer/password_autofill_agent.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46d960ae67ca98136eb883444a6bd53e75a175a2 commit 46d960ae67ca98136eb883444a6bd53e75a175a2 Author: Uladzimir Miniailau <miniailau@google.com> Date: Thu Nov 29 17:53:56 2018 Store only relevant information at the form structure cache Bug: 898109 Change-Id: If15a8ea69c7fd77e084b5766ea23afb6a4f1224e Reviewed-on: https://chromium-review.googlesource.com/c/1354921 Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#612254} [modify] https://crrev.com/46d960ae67ca98136eb883444a6bd53e75a175a2/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/46d960ae67ca98136eb883444a6bd53e75a175a2/components/autofill/content/renderer/password_autofill_agent.h
vabr going hobby only -> reducing involvement. Please contact me directly in urgent matters.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cca381d88c2153ca19dc9b50be90c6975c526f1 commit 4cca381d88c2153ca19dc9b50be90c6975c526f1 Author: Uladzimir Miniailau <miniailau@google.com> Date: Tue Dec 04 10:34:05 2018 Add UMA statistics about password form sending to a browser process Bug: 898109 Change-Id: If06439f4407cadb7eececb40e7321c9edc032c15 Reviewed-on: https://chromium-review.googlesource.com/c/1355135 Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#613497} [modify] https://crrev.com/4cca381d88c2153ca19dc9b50be90c6975c526f1/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/4cca381d88c2153ca19dc9b50be90c6975c526f1/components/autofill/content/renderer/password_autofill_agent.h [modify] https://crrev.com/4cca381d88c2153ca19dc9b50be90c6975c526f1/tools/metrics/histograms/enums.xml [modify] https://crrev.com/4cca381d88c2153ca19dc9b50be90c6975c526f1/tools/metrics/histograms/histograms.xml
Comment 1 by vabr@chromium.org
, Oct 23