Regression: [Print Preview] Glimpse of 'More settings' options are seen at the time of giving print command.
Reported by
dchau...@etouch.net,
Oct 23
|
|||||
Issue descriptionChrome Version: 72.0.3589.0 (Official Build) Revision 137b4abdf6e77cce5d0301d75d0e2a5c3daaf3fc-refs/branch-heads/3589@{#1} (32/64-bit) OS: Windows (7, 8, 8.1, 10), Mac (10.13.1, 10.13.6, 10.14.1) and Linux (14.04 LTS) What steps will reproduce the problem? 1. Launch Chrome, give print command on any webpage and observe. Actual: Glimpse of 'More settings' options are seen at the time of giving print command. Expected: Glimpse of 'More settings' options should not be seen at the time of giving print command. This is a regression issue, broken in M-72 series, below is manual regression range: Good build: 72.0.3583.0 (Revision: 600164) Bad build: 72.0.3584.0 (Revision: 600616) You are probably looking for a change made after 600217 (known good), but no later than 600225 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/7e3361f0a1f2962a85c8cf36b6ea2f403328419e..177774d57a744b75630cba5507c3bf1ed419aea3 Suspecting: https://chromium.googlesource.com/chromium/src/+/62f2f8f209a82db0dd5a311eb4f844bddb75c98e @xlou: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1. Provided suspect through 'Chromium bisect' script because unable to perform bisect using 'per-revision' bisect script. 2. Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting "RuntimeError: We don't have enough builds to bisect." error. Kindly review the attached screen-cast for reference. Thank you.
,
Oct 23
This is a Polymer 2 issue. New print preview has been enabled by default since 71. Tried on Canary and flipping the N-up flag did not impact the behavior, but running with --disable-features=WebUIPolymer2 fixed the problem.
,
Oct 23
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a502b3b5817e9bf000438c1f4f25f3ee0974fb61 commit a502b3b5817e9bf000438c1f4f25f3ee0974fb61 Author: rbpotter <rbpotter@chromium.org> Date: Wed Oct 24 22:28:46 2018 Print Preview: Do not expand settings at startup In Polymer 2, shouldExpandSettings_ is called when the computed property shouldShowMoreSettings_ is undefined, and returns true in this case, resulting in a flash of the expanded settings. Return false unless shouldShowMoreSettings_ is set to the boolean value of false. Bug: 898100 Change-Id: I7154772921c59ba24ba1c80901da4b962305eeac Reviewed-on: https://chromium-review.googlesource.com/c/1297605 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602494} [modify] https://crrev.com/a502b3b5817e9bf000438c1f4f25f3ee0974fb61/chrome/browser/resources/print_preview/new/app.js
,
Oct 24
,
Oct 25
Update: Rechecked this issue on Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14) and Linux(14.04) machines using latest Canary #72.0.3591.0 and issue is fixed. Hence adding TE-Verified labels. please refer the attached screen-cast for reference. Thank you. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by xlou@chromium.org
, Oct 23Owner: rbpotter@chromium.org