[bisect-kit] unable to bisect chrome local build between 72.0.3581.0 and 72.0.3582.0 |
|||
Issue descriptionSome issues 1. Chrome added and removed repo, src/third_party/shaderc/src, between the said branch. It's likely "gclient sync" missed the said repo because it appeared very short time. If so, git commit history of the said repo is not mirrored. 2. src/third_party/glslang/src changed its remote repo URL. It was https://chromium.googlesource.com/external/github.com/google/glslang.git for several months. Oct 15 it was changed to https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git Oct 16 it was reverted back to google/glslang.git Oct 21 it was changed to KhronosGroup/glslang.git again Because bisect-kit assumed remote repo is simply moving, it run 'git checkout' directly even across different remote. For the case of glslang.git, it is moving but 'git checkout' directly may not work. It will likely fail because we no longer sync the the removed repos and thus the removed repos don't contain newer CLs. 'git checkout' failed because commits are not found.
,
Oct 23
Steps to reproduce these issues: ./bisect_cr_localbuild_internal.py --session=nocturne-11167 init --old 72.0.3581.0 --new 72.0.3582.0 --chrome_root ~/bisect-workdir/nocturne-11167/chrome --chrome_mirror ~/git-mirrors/chrome ./switch_cros_cr_localbuild_internal.py --chrome_root ~/bisect-workdir/nocturne-11167/chrome --chrome_mirror ~/git-mirrors/chrome --nobuild chromeos6-row6-rack15-host5.cros '72.0.3581.0~72.0.3582.0/302'
,
Oct 23
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/88b173460df5ffdcf99ab6189d83aa890872a84c commit 88b173460df5ffdcf99ab6189d83aa890872a84c Author: Kuang-che Wu <kcwu@chromium.org> Date: Tue Oct 23 14:09:17 2018 bisect-kit: fix exceptions when switch chrome code 1. wrong python syntax when generate gclient project list 2. gclient will leave removed repos on disk by default but bisect-kit assumes the tree is clean. Add --delete_unversioned_trees to ask gclient to delete them. BUG= chromium:898097 TEST=./switch_cros_cr_localbuild_internal.py '72.0.3581.0~72.0.3582.0/302' Change-Id: I1e6492883ffd0385eb4f143c48ac77f781e5fe62 Reviewed-on: https://chromium-review.googlesource.com/1295935 Commit-Ready: Kuang-che Wu <kcwu@chromium.org> Tested-by: Kuang-che Wu <kcwu@chromium.org> Reviewed-by: Chung-yih Wang <cywang@chromium.org> Reviewed-by: Chi-Ngai Wan <cnwan@google.com> [modify] https://crrev.com/88b173460df5ffdcf99ab6189d83aa890872a84c/bisect_kit/gclient_util.py
,
Oct 31
|
|||
►
Sign in to add a comment |
|||
Comment 1 by kcwu@chromium.org
, Oct 23