New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 898094 link

Starred by 1 user
Status: Fixed
Owner:
tetsui@chromium.org
Closed: Oct 25
Cc:
█ mitsuruo@google.com
yamaguchi@chromium.org
tetsui@chromium.org
█ toshikikikuchi@google.com
█ yoshiki@chromium.org
edcourtney@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Inline settings background isn't shown correctly

Project Member Reported by tetsui@chromium.org, Oct 23 
Chrome Version: ToT (811c6675e5641e80b82b46ad626d93f95311f6da)
OS: Chrome OS

What steps will reproduce the problem?
(1) Show a notification from https://tests.peter.sh/notification-generator/
(2) Press gear settings button

What is the expected result?
Background should be painted properly

What happens instead?
Bottom half of the background is still white

Comment 1 by tetsui@chromium.org, Oct 23 

Screenshot:
Screenshot 2018-10-23 at 5.50.34 PM.png
12.7 KB View Download

Comment 2 by tetsui@chromium.org, Oct 23

Labels: -Pri-3 ReleaseBlock-Stable M-71 Pri-2

Comment 3 by tetsui@chromium.org, Oct 25

Cc: toshikikikuchi@google.com
Owner: tetsui@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35cfc1aed4eb74a8351902ae3a24cb630cb1b83b

commit 35cfc1aed4eb74a8351902ae3a24cb630cb1b83b
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Thu Oct 25 08:03:17 2018

Revert "Unified: Round corners of inline settings."

This reverts commit 446e74224f0d0a799a4db71588650808945873d0.

Reason for revert: regression for popups  https://crbug.com/898094 

Original change's description:
> Unified: Round corners of inline settings.
> 
> In UnifiedSystemTray, a notification can have different radii for the
> top and the bottom corners. This CL applies custom mask to ink drop of
> NotificationViewMD so that these corners are properly painted even in
> inline settings.
> 
> TEST=manual
> BUG=878772
> 
> Change-Id: Ib8bf5f8e34c3f30c1e8ac3b32ee6d4a1ff6a6584
> Reviewed-on: https://chromium-review.googlesource.com/c/1195258
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598609}

TBR=yoshiki@chromium.org,tetsui@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 878772, 898094 
Change-Id: I65c0281cf1ff3448d61344bb2b447bbe3ec05ef5
Reviewed-on: https://chromium-review.googlesource.com/c/1298529
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602642}
[modify] https://crrev.com/35cfc1aed4eb74a8351902ae3a24cb630cb1b83b/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/35cfc1aed4eb74a8351902ae3a24cb630cb1b83b/ui/message_center/views/notification_view_md.h

Comment 5 by tetsui@chromium.org, Oct 25

Labels: Merge-Request-71
Status: Fixed (was: Started)

Comment 6 by kbleicher@google.com, Oct 25 

Approving merge to M71 Chrome OS since this appears to be limited to a revert.  Please open the request if otherwise.

Comment 7 by kbleicher@google.com, Oct 25

Labels: -Merge-Request-71 Merge-Approved-71
Project Member

Comment 8 by cr-audit...@appspot.gserviceaccount.com, Oct 26

Labels: -Merge-Approved-71 Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/c32ed7b7d91dc4adf11417cf01cec6aadaaf57ba

Commit: c32ed7b7d91dc4adf11417cf01cec6aadaaf57ba
Author: tetsui@chromium.org
Commiter: tetsui@chromium.org
Date: 2018-10-26 02:17:28 +0000 UTC

Revert "Unified: Round corners of inline settings."

This reverts commit 446e74224f0d0a799a4db71588650808945873d0.

Reason for revert: regression for popups  https://crbug.com/898094 

Original change's description:
> Unified: Round corners of inline settings.
> 
> In UnifiedSystemTray, a notification can have different radii for the
> top and the bottom corners. This CL applies custom mask to ink drop of
> NotificationViewMD so that these corners are properly painted even in
> inline settings.
> 
> TEST=manual
> BUG=878772
> 
> Change-Id: Ib8bf5f8e34c3f30c1e8ac3b32ee6d4a1ff6a6584
> Reviewed-on: https://chromium-review.googlesource.com/c/1195258
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598609}

TBR=yoshiki@chromium.org,tetsui@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 878772, 898094 
Change-Id: I65c0281cf1ff3448d61344bb2b447bbe3ec05ef5
Reviewed-on: https://chromium-review.googlesource.com/c/1298529
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602642}(cherry picked from commit 35cfc1aed4eb74a8351902ae3a24cb630cb1b83b)
Reviewed-on: https://chromium-review.googlesource.com/c/1300816
Cr-Commit-Position: refs/branch-heads/3578@{#341}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 26

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c32ed7b7d91dc4adf11417cf01cec6aadaaf57ba

commit c32ed7b7d91dc4adf11417cf01cec6aadaaf57ba
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Fri Oct 26 02:17:28 2018

Revert "Unified: Round corners of inline settings."

This reverts commit 446e74224f0d0a799a4db71588650808945873d0.

Reason for revert: regression for popups  https://crbug.com/898094 

Original change's description:
> Unified: Round corners of inline settings.
> 
> In UnifiedSystemTray, a notification can have different radii for the
> top and the bottom corners. This CL applies custom mask to ink drop of
> NotificationViewMD so that these corners are properly painted even in
> inline settings.
> 
> TEST=manual
> BUG=878772
> 
> Change-Id: Ib8bf5f8e34c3f30c1e8ac3b32ee6d4a1ff6a6584
> Reviewed-on: https://chromium-review.googlesource.com/c/1195258
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598609}

TBR=yoshiki@chromium.org,tetsui@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 878772, 898094 
Change-Id: I65c0281cf1ff3448d61344bb2b447bbe3ec05ef5
Reviewed-on: https://chromium-review.googlesource.com/c/1298529
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602642}(cherry picked from commit 35cfc1aed4eb74a8351902ae3a24cb630cb1b83b)
Reviewed-on: https://chromium-review.googlesource.com/c/1300816
Cr-Commit-Position: refs/branch-heads/3578@{#341}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/c32ed7b7d91dc4adf11417cf01cec6aadaaf57ba/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/c32ed7b7d91dc4adf11417cf01cec6aadaaf57ba/ui/message_center/views/notification_view_md.h
►

Sign in to add a comment