New issue
Advanced search Search tips

Issue 898062 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: inspector-protocol/runtime/runtime-console-log-handle-navigate.js



Sign in to add a comment

inspector-protocol/runtime/runtime-console-log-handle-navigate.js is flaky

Project Member Reported by Findit, Oct 23

Issue description


Flaky test: inspector-protocol/runtime/runtime-console-log-handle-navigate.js
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.win/WebKit%20Win10/42499
Test output log: https://chromium-swarm.appspot.com/task?id=40b7f42d8a5f3910
Culprit (75.4% confidence): r601826
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKgAWNocm9taXVtLndpbi9XZWJLaXQgV2luMTAvNDI0OTkvd2Via2l0X2xheW91dF90ZXN0cyBvbiBXaW5kb3dzLTEwLTE1MDYzL2FXNXpjR1ZqZEc5eUxYQnliM1J2WTI5c0wzSjFiblJwYldVdmNuVnVkR2x0WlMxamIyNXpiMnhsTFd4dlp5MW9ZVzVrYkdVdGJtRjJhV2RoZEdVdWFuTT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20inspector-protocol/runtime/runtime-console-log-handle-navigate.js&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKgAWNocm9taXVtLndpbi9XZWJLaXQgV2luMTAvNDI0OTkvd2Via2l0X2xheW91dF90ZXN0cyBvbiBXaW5kb3dzLTEwLTE1MDYzL2FXNXpjR1ZqZEc5eUxYQnliM1J2WTI5c0wzSjFiblJwYldVdmNuVnVkR2x0WlMxamIyNXpiMnhsTFd4dlp5MW9ZVzVrYkdVdGJtRjJhV2RoZEdVdWFuTT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
 
Project Member

Comment 1 by Findit, Oct 23


Flaky test: inspector-protocol/runtime/runtime-console-log-handle-navigate.js
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%281%29/84965
Test output log: https://chromium-swarm.appspot.com/task?id=40b81514d15dd410
Culprit (70.0% confidence): r601826
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKOAWNocm9taXVtLndpbi9XaW43IFRlc3RzICgxKS84NDk2NS93ZWJraXRfbGF5b3V0X3Rlc3RzL2FXNXpjR1ZqZEc5eUxYQnliM1J2WTI5c0wzSjFiblJwYldVdmNuVnVkR2x0WlMxamIyNXpiMnhsTFd4dlp5MW9ZVzVrYkdVdGJtRjJhV2RoZEdVdWFuTT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20inspector-protocol/runtime/runtime-console-log-handle-navigate.js&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKOAWNocm9taXVtLndpbi9XaW43IFRlc3RzICgxKS84NDk2NS93ZWJraXRfbGF5b3V0X3Rlc3RzL2FXNXpjR1ZqZEc5eUxYQnliM1J2WTI5c0wzSjFiblJwYldVdmNuVnVkR2x0WlMxamIyNXpiMnhsTFd4dlp5MW9ZVzVrYkdVdGJtRjJhV2RoZEdVdWFuTT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Components: Infra>Client>V8
Owner: kozyatinskiy@chromium.org
Suspect v8-roll causes this issue:
https://chromium.googlesource.com/v8/v8/+/66daabcca996bf581d2a85b0d942a64fa7c43f07

https://test-results.appspot.com/data/layout_results/WebKit_Linux_Trusty_ASAN/17394/webkit_layout_tests/layout-test-results/results.html
crash log for renderer (pid <unknown>):
STDOUT: <empty>
STDERR: =================================================================
STDERR: ==1==ERROR: AddressSanitizer: heap-use-after-free on address 0x61100000ead0 at pc 0x000007953ca8 bp 0x7fff3d24c750 sp 0x7fff3d24c748
STDERR: READ of size 1 at 0x61100000ead0 thread T0 (content_shell)
STDERR:     #0 0x7953ca7 in v8_inspector::InjectedScript::wrapObject(v8::Local<v8::Value>, v8_inspector::String16 const&, bool, bool, v8::MaybeLocal<v8::Value>, int, std::__1::unique_ptr<v8_inspector::protocol::Runtime::RemoteObject, std::__1::default_delete<v8_inspector::protocol::Runtime::RemoteObject> >*) const ./../../v8/src/inspector/injected-script.cc:409:7
STDERR:     #1 0x7953158 in v8_inspector::InjectedScript::wrapObject(v8::Local<v8::Value>, v8_inspector::String16 const&, bool, bool, std::__1::unique_ptr<v8_inspector::protocol::Runtime::RemoteObject, std::__1::default_delete<v8_inspector::protocol::Runtime::RemoteObject> >*) const ./../../v8/src/inspector/injected-script.cc:385:10
STDERR:     #2 0x7a1b1bf in v8_inspector::V8InspectorSessionImpl::wrapObject(v8::Local<v8::Context>, v8::Local<v8::Value>, v8_inspector::String16 const&, bool) ./../../v8/src/inspector/v8-inspector-session-impl.cc:288:19
STDERR:     #3 0x7981876 in v8_inspector::V8ConsoleMessage::wrapArguments(v8_inspector::V8InspectorSessionImpl*, bool) const ./../../v8/src/inspector/v8-console-message.cc:278:20
STDERR:     #4 0x7982d06 in v8_inspector::V8ConsoleMessage::reportToFrontend(v8_inspector::protocol::Runtime::Frontend*, v8_inspector::V8InspectorSessionImpl*, bool) const ./../../v8/src/inspector/v8-console-message.cc:327:21
...
Cc: dgozman@chromium.org
Components: -Infra>Client>V8 Blink>JavaScript
Cc: kozy@chromium.org
Cc: hablich@chromium.org yigu@chromium.org
 Issue 898156  has been merged into this issue.
Is kozy@ the same person as kozyatinskiy@? If so please reassign to kozy@ and we will remove the sheriff label. Thanks!
Cc: -kozy@chromium.org
Owner: kozy@chromium.org
Status: Assigned (was: Untriaged)
Test is still failing; I'll disable it.
Labels: Test-Disabled
Never mind, it was disabled in  bug 898156 . kozy@, PTAL!
Labels: -Sheriff-Chromium
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/v8/v8/+/1297290
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85fb5d0342c7bd951d129c0dc782a952d74023d9

commit 85fb5d0342c7bd951d129c0dc782a952d74023d9
Author: Yi Gu <yigu@chromium.org>
Date: Tue Oct 23 21:09:55 2018

Mark inspector-protocol/runtime/runtime-console-log-handle-navigate.js Crash

Findit suspects that it was caused by a v8 update. TBR owners for
further investigation.

TBR=kozy@chromium.org
NOTRY=true

Bug:  898062 
Change-Id: I9a77f0d40f73d57f0fd54588ffd96a74d98dd2c1
Reviewed-on: https://chromium-review.googlesource.com/c/1297392
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602093}
[modify] https://crrev.com/85fb5d0342c7bd951d129c0dc782a952d74023d9/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1e505a036692a488d16b9e091d61fa98ca77855a

commit 1e505a036692a488d16b9e091d61fa98ca77855a
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Wed Oct 24 00:08:10 2018

inspector: do not use injected script after wrapValue call

wrapValue can destroy injected script.

R=dgozman@chromium.org

Bug:  chromium:898062 
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I60c8d4a4b510b896a175346a3ba72ca8be43bca5
Reviewed-on: https://chromium-review.googlesource.com/c/1297290
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56919}
[modify] https://crrev.com/1e505a036692a488d16b9e091d61fa98ca77855a/src/inspector/injected-script.cc

The issue should be fixed in V8, I will wait until V8 is rolled to Chromium and will enable test back.
Status: Fixed (was: Started)

Sign in to add a comment