New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 898061 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

unable to join wifi with PSK password

Project Member Reported by osh...@chromium.org, Oct 23

Issue description

72.0.3590.0 / 11174.0.0

repro step
1) Selet wifi with PSK
2) In network dialog, type in password, then return.

Nothing seem to happen after this. I also clicked "Connect" button
but no luck.

steven, can you find right owner?
 
Does this happen with multiple wifi networks?

Can you open up the JS developer console and see if there are any other messages, or look at the log output? Or file a feedback report?


Cc: steve...@chromium.org hendrich@chromium.org
Owner: nikitapodguzov@chromium.org
Actually, this repros with a fake network:

ERROR:CONSOLE(34)] "Uncaught Error: Invalid value for argument 2. Property 'Name': Expected 'string' but got 'object'.", source: extensions::schemaUtils (34)

-> nikitapodguzov@, this is almost certainly a result of https://chromium-review.googlesource.com/c/1290914

We need a quick fix or a revert.


Yes there is a js error: 


Uncaught Error: Invalid value for argument 2. Property 'Name': Expected 'string' but got 'object'.
   at validate (extensions::schemaUtils:34)
   at Object.normalizeArgumentsAndValidate (extensions::schemaUtils:119)
   at Object.<anonymous> (extensions::binding:363)
   at HTMLElement.saveAndConnect_ (crisper.js:64)
   at HTMLElement.connect (crisper.js:64)
   at HTMLElement.connectIfConfigured_ (crisper.js:64)
   at handler (polymer-extracted.js:491)
   at HTMLElement.decorated (polymer-extracted.js:4566)
   at HTMLElement.fire (polymer-extracted.js:1279)
   at HTMLElement.onInputKeypress_ (crisper.js:60)

Not sure if that cl is related because I still can repro on ToT that I just sync'ed.
yeah, the CL I mentioned is out for review and should fix the issue. We just discovered the same problem a few minutes ago as well.

@nikitapodguzov: you can add this bug number to your CL description, so this thread gets updated once your CL lands.
Ah, sorry I thought it's already landed because bug was closed. Thanks.
Status: Started (was: Assigned)
Sorry, the CL fixing this issue (@hendrich already mentioned it) will be submitted soon.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dd034999d07755b42933721c44162edcb5bf4e4

commit 1dd034999d07755b42933721c44162edcb5bf4e4
Author: Nikita Podguzov <nikitapodguzov@chromium.org>
Date: Tue Oct 23 17:29:45 2018

Fix handling name provided by ManagedProperties.

Bug:  898061 
Change-Id: I2fc32c8b366ea19837e0d53d29e0aad3bd965271
Reviewed-on: https://chromium-review.googlesource.com/c/1296596
Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602002}
[modify] https://crrev.com/1dd034999d07755b42933721c44162edcb5bf4e4/ui/webui/resources/cr_components/chromeos/network/network_config.js

Status: Fixed (was: Started)
Cc: mkarkada@chromium.org djmm@chromium.org alemate@chromium.org pucchakayala@chromium.org songsuk@chromium.org ajha@chromium.org
 Issue 898428  has been merged into this issue.
Issue 898585 has been merged into this issue.

Sign in to add a comment