Issue metadata
Sign in to add a comment
|
accessibility/table-header-column-row.html is flaky |
||||||||||||||||||||||
Issue descriptionFlaky test: accessibility/table-header-column-row.html Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/75214 Test output log: https://chromium-swarm.appspot.com/task?id=40b6558b243e9210 Culprit (70.0% confidence): r601651 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyrAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ2Y2hyb21pdW0ubGludXgvTGludXggVGVzdHMgKGRiZykoMSkvNzUyMTQvd2Via2l0X2xheW91dF90ZXN0cy9ZV05qWlhOemFXSnBiR2wwZVM5MFlXSnNaUzFvWldGa1pYSXRZMjlzZFcxdUxYSnZkeTVvZEcxcwwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20accessibility/table-header-column-row.html&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyrAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ2Y2hyb21pdW0ubGludXgvTGludXggVGVzdHMgKGRiZykoMSkvNzUyMTQvd2Via2l0X2xheW91dF90ZXN0cy9ZV05qWlhOemFXSnBiR2wwZVM5MFlXSnNaUzFvWldGa1pYSXRZMjlzZFcxdUxYSnZkeTVvZEcxcwwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Oct 23
When it passes this test take 17.4s, the timeout is 18s. Gonna mark it as a slow test.
,
Oct 23
Going back ~300 commits, this was still slow.
,
Oct 23
,
Oct 23
,
Oct 23
cc oksamyt who submitted the culprit. That patch is mojom related so maybe oksamyt@ has inputs regarding the racing here.
,
Oct 23
The test was very slow before that cl too. I don't think the mojom stuff is connected TBH
,
Oct 23
Right. According to [1] it was slow before that patch. [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&showExpectations=true&tests=accessibility%2Ftable-header-column-row.html Possible regression range is: https://chromium.googlesource.com/chromium/src/+log/f0536f4628fc12b899481c592e7672740b871981%5E..02b6cf719bbc4f9b7e792b760c91c2dd50f7b4d6?pretty=fuller&n=
,
Oct 23
Note that there was a v8 roll within that range which has caused other tests flaky. See issue 898062 .
,
Oct 23
r601651 changes a build target's dependencies and shouldn't influence anything in runtime, so I agree it's unlikely to be related to the slow/flaky tests.
,
Oct 23
,
Oct 24
The test is just slow, on the borderline of the timeout. I've sent a CL to mark it as a slow test so that the timeout is much larger. https://crrev.com/c/1295758
,
Oct 29
accessibility/table-header-column-row.html is flaky. Findit has detected 8 new flake occurrences of this test. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUgsSBUZsYWtlIkdjaHJvbWl1bUB3ZWJraXRfbGF5b3V0X3Rlc3RzQGFjY2Vzc2liaWxpdHkvdGFibGUtaGVhZGVyLWNvbHVtbi1yb3cuaHRtbAw. Since this test is still flaky, this issue has been moved back onto the Sheriff Bug Queue if it's not already there. If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20accessibility/table-header-column-row.html&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUgsSBUZsYWtlIkdjaHJvbWl1bUB3ZWJraXRfbGF5b3V0X3Rlc3RzQGFjY2Vzc2liaWxpdHkvdGFibGUtaGVhZGVyLWNvbHVtbi1yb3cuaHRtbAw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Oct 30
Actually this slowness is due to something funny with .innerText. I have filed https://crbug.com/900098 with a simple repro case.
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6637b4ee2b61bcf6dbf2ae3fa0a0010198ee80b0 commit 6637b4ee2b61bcf6dbf2ae3fa0a0010198ee80b0 Author: Fergal Daly <fergal@chromium.org> Date: Tue Oct 30 14:00:46 2018 Repeatedly appending to .innerText is slow and causing timeouts. Change the code to build an array of strings and then use join to avoid repeated appends. Bug: 898049 Change-Id: I194a9da3444d097dd30f4738a795391f44c6a22b Reviewed-on: https://chromium-review.googlesource.com/c/1306965 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#603884} [modify] https://crrev.com/6637b4ee2b61bcf6dbf2ae3fa0a0010198ee80b0/third_party/WebKit/LayoutTests/resources/accessibility-helper.js
,
Oct 30
,
Oct 30
Issue 899885 has been merged into this issue.
,
Oct 30
Merge issue 899885 as this test was also failed on Win7. However, if the patch above has fixed the issue, please enable these two tests.
,
Oct 31
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2be6c3e2c1e468074a8eaa71d61345403c7d20ee commit 2be6c3e2c1e468074a8eaa71d61345403c7d20ee Author: Fergal Daly <fergal@chromium.org> Date: Wed Oct 31 04:19:07 2018 Remove flaky test entry for 2 accessibility tests. * accessibility/element-role-mapping-normal.html * accessibility/table-header-column-row.html The flakiness is due to slowness which is fixed by https://crrev.com/c/1306965 Bug: 898049 , 899885 Change-Id: If4a9a770833344b3b55e89bbc3379f3cc9560e0e Reviewed-on: https://chromium-review.googlesource.com/c/1309375 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#604145} [modify] https://crrev.com/2be6c3e2c1e468074a8eaa71d61345403c7d20ee/third_party/WebKit/LayoutTests/TestExpectations |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by fergal@google.com
, Oct 23