New issue
Advanced search Search tips

Issue 898049 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 30
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: accessibility/table-header-column-row.html



Sign in to add a comment

accessibility/table-header-column-row.html is flaky

Project Member Reported by Findit, Oct 23

Issue description

Cluprit CL shouldn't have an impact on this and I couldn't repro locally but then I started another build on my machine and the test started failing. It seems like content_shell is pinned at 100% during this test and if it has to compete for CPU time, it's likely to time out.

Digging a bit further.
When it passes this test take 17.4s, the timeout is 18s. Gonna mark it as a slow test.
Going back ~300 commits, this was still slow.
Owner: fergal@chromium.org
Status: Started (was: Untriaged)
Cc: yigu@chromium.org
 Issue 897849  has been merged into this issue.
Cc: oksamyt@chromium.org
cc oksamyt who submitted the culprit. That patch is mojom related so maybe oksamyt@ has inputs regarding the racing here.
The test was very slow before that cl too. I don't think the mojom stuff is
connected TBH
Note that there was a v8 roll within that range which has caused other tests flaky. See  issue 898062 .
r601651 changes a build target's dependencies and shouldn't influence anything in runtime, so I agree it's unlikely to be related to the slow/flaky tests.
Labels: -Sheriff-Chromium
Looks like the test was already marked flaky in  bug 897849 .
The test is just slow, on the borderline of the timeout. I've sent a CL to mark it as a slow test so that the timeout is much larger.

https://crrev.com/c/1295758

Actually this slowness is due to something funny with .innerText. I have filed https://crbug.com/900098 with a simple repro case.
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6637b4ee2b61bcf6dbf2ae3fa0a0010198ee80b0

commit 6637b4ee2b61bcf6dbf2ae3fa0a0010198ee80b0
Author: Fergal Daly <fergal@chromium.org>
Date: Tue Oct 30 14:00:46 2018

Repeatedly appending to .innerText is slow and causing timeouts.

Change the code to build an array of strings and then use join to
avoid repeated appends.

Bug:  898049 
Change-Id: I194a9da3444d097dd30f4738a795391f44c6a22b
Reviewed-on: https://chromium-review.googlesource.com/c/1306965
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603884}
[modify] https://crrev.com/6637b4ee2b61bcf6dbf2ae3fa0a0010198ee80b0/third_party/WebKit/LayoutTests/resources/accessibility-helper.js

Status: Fixed (was: Started)
 Issue 899885  has been merged into this issue.
Merge  issue 899885  as this test was also failed on Win7. However, if the patch above has fixed the issue, please enable these two tests.
Cc: fergal@chromium.org
 Issue 900311  has been merged into this issue.
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2be6c3e2c1e468074a8eaa71d61345403c7d20ee

commit 2be6c3e2c1e468074a8eaa71d61345403c7d20ee
Author: Fergal Daly <fergal@chromium.org>
Date: Wed Oct 31 04:19:07 2018

Remove flaky test entry for 2 accessibility tests.
 * accessibility/element-role-mapping-normal.html
 * accessibility/table-header-column-row.html

The flakiness is due to slowness which is fixed by
https://crrev.com/c/1306965


Bug:  898049 , 899885 
Change-Id: If4a9a770833344b3b55e89bbc3379f3cc9560e0e
Reviewed-on: https://chromium-review.googlesource.com/c/1309375
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604145}
[modify] https://crrev.com/2be6c3e2c1e468074a8eaa71d61345403c7d20ee/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment