New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 898043 link

Starred by 3 users
Status: Fixed
Owner:
█ rjwright@chromium.org
Last visit > 30 days ago
Closed: Nov 22
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

CrostiniRestarter does not differentiate between container start and container set up in error reports

Project Member Reported by rjwright@chromium.org, Oct 23 
We need to add an observer callback in StartLxdContainerFinished so we can tell the difference between failures in container setup and container start, and report that to UMA.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7f16769af0e6f707431f426a7f9d97f6cf2f4a6

commit e7f16769af0e6f707431f426a7f9d97f6cf2f4a6
Author: Renee Wright <rjwright@chromium.org>
Date: Wed Oct 24 02:41:29 2018

Add method for handling errors in setting up Crostini Container

This allows up to discriminate between container setup errors and
container startup errors in the UMA

Bug:  898043 
Change-Id: I71921b6980c3f1f85c27ecee178db64a93bed232
Reviewed-on: https://chromium-review.googlesource.com/c/1295630
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Renée Wright <rjwright@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602225}
[modify] https://crrev.com/e7f16769af0e6f707431f426a7f9d97f6cf2f4a6/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/e7f16769af0e6f707431f426a7f9d97f6cf2f4a6/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/e7f16769af0e6f707431f426a7f9d97f6cf2f4a6/chrome/browser/chromeos/crostini/crostini_manager.h
[modify] https://crrev.com/e7f16769af0e6f707431f426a7f9d97f6cf2f4a6/chrome/browser/chromeos/crostini/crostini_manager_unittest.cc
[modify] https://crrev.com/e7f16769af0e6f707431f426a7f9d97f6cf2f4a6/chrome/browser/ui/views/crostini/crostini_installer_view.cc
[modify] https://crrev.com/e7f16769af0e6f707431f426a7f9d97f6cf2f4a6/chrome/browser/ui/views/crostini/crostini_installer_view.h

Comment 2 by rjwright@chromium.org, Nov 22

Status: Fixed (was: Started)
►

Sign in to add a comment