In WebViewWebClient::AllowCertificateError(). It should contain domain / error code and localized error message for each type of SSL errors.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af760c9155256a267d8f3a284aa52492ae57b3c9 commit af760c9155256a267d8f3a284aa52492ae57b3c9 Author: Hiroshi Ichikawa <ichikawa@chromium.org> Date: Mon Nov 12 01:55:19 2018 Add more information to |error| of -didFailFavigationWithSSLError:. Add error.localizedDescription and error.userInfo[CWVCertStatusKey]. Bug: 898037 Change-Id: I3e552330378992574d7c08f96f343aba6a7b4d29 Reviewed-on: https://chromium-review.googlesource.com/c/1325578 Reviewed-by: Carlos IL <carlosil@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#607127} [modify] https://crrev.com/af760c9155256a267d8f3a284aa52492ae57b3c9/ios/web_view/BUILD.gn [modify] https://crrev.com/af760c9155256a267d8f3a284aa52492ae57b3c9/ios/web_view/internal/DEPS [add] https://crrev.com/af760c9155256a267d8f3a284aa52492ae57b3c9/ios/web_view/internal/cwv_navigation_delegate.mm [modify] https://crrev.com/af760c9155256a267d8f3a284aa52492ae57b3c9/ios/web_view/internal/cwv_ssl_status.mm [modify] https://crrev.com/af760c9155256a267d8f3a284aa52492ae57b3c9/ios/web_view/internal/cwv_ssl_status_internal.h [modify] https://crrev.com/af760c9155256a267d8f3a284aa52492ae57b3c9/ios/web_view/internal/web_view_web_client.mm [modify] https://crrev.com/af760c9155256a267d8f3a284aa52492ae57b3c9/ios/web_view/public/cwv_navigation_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87db0e76078d63cad178c06262438ba5ae9351b4 commit 87db0e76078d63cad178c06262438ba5ae9351b4 Author: Patrik Höglund <phoglund@chromium.org> Date: Mon Nov 12 13:01:55 2018 Revert "Add more information to |error| of -didFailFavigationWithSSLError:." This reverts commit af760c9155256a267d8f3a284aa52492ae57b3c9. Reason for revert: Appears to cause flaky crashes in external/wpt/webusb/idlharness.https.any.worker.html. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/6367. The crash stack trace mentions SSL. If this CL is innocent, then please just reland. Original change's description: > Add more information to |error| of -didFailFavigationWithSSLError:. > > Add error.localizedDescription and error.userInfo[CWVCertStatusKey]. > > Bug: 898037 > Change-Id: I3e552330378992574d7c08f96f343aba6a7b4d29 > Reviewed-on: https://chromium-review.googlesource.com/c/1325578 > Reviewed-by: Carlos IL <carlosil@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607127} TBR=eugenebut@chromium.org,ichikawa@chromium.org,carlosil@chromium.org Change-Id: Ieffa8431079996675b1d53f058e4059fa74b8d09 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898037 , 904345 Reviewed-on: https://chromium-review.googlesource.com/c/1329972 Reviewed-by: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#607205} [modify] https://crrev.com/87db0e76078d63cad178c06262438ba5ae9351b4/ios/web_view/BUILD.gn [modify] https://crrev.com/87db0e76078d63cad178c06262438ba5ae9351b4/ios/web_view/internal/DEPS [delete] https://crrev.com/2e38d313a49bc8c28b8ce38f004776dbf4357b99/ios/web_view/internal/cwv_navigation_delegate.mm [modify] https://crrev.com/87db0e76078d63cad178c06262438ba5ae9351b4/ios/web_view/internal/cwv_ssl_status.mm [modify] https://crrev.com/87db0e76078d63cad178c06262438ba5ae9351b4/ios/web_view/internal/cwv_ssl_status_internal.h [modify] https://crrev.com/87db0e76078d63cad178c06262438ba5ae9351b4/ios/web_view/internal/web_view_web_client.mm [modify] https://crrev.com/87db0e76078d63cad178c06262438ba5ae9351b4/ios/web_view/public/cwv_navigation_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e7d961a7165c8e42a90cd752adb9c9be423d9b0 commit 8e7d961a7165c8e42a90cd752adb9c9be423d9b0 Author: Hiroshi Ichikawa <ichikawa@chromium.org> Date: Mon Nov 12 23:45:36 2018 Reland "Add more information to |error| of -didFailFavigationWithSSLError:." This reverts commit 87db0e76078d63cad178c06262438ba5ae9351b4. Reason for revert: The original CL was reverted as a culprit of a flaky crash. But it turned out to be innocent per discussion in https://crrev.com/c/1329972. Original change's description: > Revert "Add more information to |error| of -didFailFavigationWithSSLError:." > > This reverts commit af760c9155256a267d8f3a284aa52492ae57b3c9. > > Reason for revert: Appears to cause flaky crashes in external/wpt/webusb/idlharness.https.any.worker.html. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/6367. The crash stack trace mentions SSL. If this CL is innocent, then please just reland. > > Original change's description: > > Add more information to |error| of -didFailFavigationWithSSLError:. > > > > Add error.localizedDescription and error.userInfo[CWVCertStatusKey]. > > > > Bug: 898037 > > Change-Id: I3e552330378992574d7c08f96f343aba6a7b4d29 > > Reviewed-on: https://chromium-review.googlesource.com/c/1325578 > > Reviewed-by: Carlos IL <carlosil@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#607127} > > TBR=eugenebut@chromium.org,ichikawa@chromium.org,carlosil@chromium.org > > Change-Id: Ieffa8431079996675b1d53f058e4059fa74b8d09 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 898037 , 904345 > Reviewed-on: https://chromium-review.googlesource.com/c/1329972 > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607205} TBR=phoglund@chromium.org,eugenebut@chromium.org,ichikawa@chromium.org,carlosil@chromium.org Change-Id: I4ac81df8f2c1386acc0683c0a03e5d022a826b95 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898037 , 904345 Reviewed-on: https://chromium-review.googlesource.com/c/1332967 Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#607372} [modify] https://crrev.com/8e7d961a7165c8e42a90cd752adb9c9be423d9b0/ios/web_view/BUILD.gn [modify] https://crrev.com/8e7d961a7165c8e42a90cd752adb9c9be423d9b0/ios/web_view/internal/DEPS [add] https://crrev.com/8e7d961a7165c8e42a90cd752adb9c9be423d9b0/ios/web_view/internal/cwv_navigation_delegate.mm [modify] https://crrev.com/8e7d961a7165c8e42a90cd752adb9c9be423d9b0/ios/web_view/internal/cwv_ssl_status.mm [modify] https://crrev.com/8e7d961a7165c8e42a90cd752adb9c9be423d9b0/ios/web_view/internal/cwv_ssl_status_internal.h [modify] https://crrev.com/8e7d961a7165c8e42a90cd752adb9c9be423d9b0/ios/web_view/internal/web_view_web_client.mm [modify] https://crrev.com/8e7d961a7165c8e42a90cd752adb9c9be423d9b0/ios/web_view/public/cwv_navigation_delegate.h
Comment 1 by ichikawa@chromium.org
, Oct 23Status: Assigned (was: Untriaged)