video_encode_accelerator_unittest was not built by trybots |
|||
Issue descriptionThis commit: https://crrev.com/04f8f2c062f67483fdc6b0986a31ecb8195e9c90 broke the build yesterday https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-rel/4802 It seems like it should have been caught by the trybots but the analyser decided that it didn't need to be built by the trybot. E.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win_optional_gpu_tests_rel/9585 This shouldn't happen, I don't really know what the right fix it, I can see that this test is guarded with if (use_v4l2_codec || use_vaapi || is_mac || is_win) { test("video_encode_accelerator_unittest") { but I don't know why that prevented it from being built by all trybots.
,
Oct 23
I think I changed VEA unittest immediately before it was merged. At that time, all the trybots had been done. It somehow lead the trybots would not run again. It should run trybots again definitely.
,
Oct 23
I tried breaking the test. The only bots that failed were chromeos-amd64-generic-rel chromeos-daisy-rel https://chromium-review.googlesource.com/c/chromium/src/+/1295755 It seems like more of them should have failed but I don't know.
,
Oct 26
,
Jan 18
(4 days ago)
tmathmeyer@ for triage. |
|||
►
Sign in to add a comment |
|||
Comment 1 by fergal@google.com
, Oct 23