New issue
Advanced search Search tips

Issue 897986 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Proj-Servicification

Blocking:
issue 827532



Sign in to add a comment

Get MergeSessionTest.XHRThrottle working in ChromeOS with network service enabled

Project Member Reported by rmcelrath@chromium.org, Oct 23

Issue description

MergeSessionTest.XHRThrottle fails with the network service enabled on ChromeOS. The ChromeOS test filter file says it's because MergeSessionResourceThrottle needs to be migrated to a URLLoaderThrottle.

https://cs.chromium.org/chromium/src/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter?l=10
 
Labels: -Pri-3 Proj-Servicification-Canary M-72 Pri-1
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/809d8fb01773e476e122ad1739530caa3d02dfed

commit 809d8fb01773e476e122ad1739530caa3d02dfed
Author: Chris Mumford <cmumford@google.com>
Date: Sat Nov 10 12:26:11 2018

Combined RendererConfiguration configuration params into struct.

Combined the four configuration parameters to
RendererConfiguration::SetConfiguration() into a structure to
simplify current implementation and future expansion.

Bug: 897986
Change-Id: Id931218928c6c3c6bf2e4f52da7605c40dbbfbb7
Reviewed-on: https://chromium-review.googlesource.com/c/1318434
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607123}
[modify] https://crrev.com/809d8fb01773e476e122ad1739530caa3d02dfed/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/809d8fb01773e476e122ad1739530caa3d02dfed/chrome/browser/profiles/renderer_updater.cc
[modify] https://crrev.com/809d8fb01773e476e122ad1739530caa3d02dfed/chrome/common/google_url_loader_throttle.cc
[modify] https://crrev.com/809d8fb01773e476e122ad1739530caa3d02dfed/chrome/common/google_url_loader_throttle.h
[modify] https://crrev.com/809d8fb01773e476e122ad1739530caa3d02dfed/chrome/common/renderer_configuration.mojom
[modify] https://crrev.com/809d8fb01773e476e122ad1739530caa3d02dfed/chrome/renderer/chrome_render_thread_observer.cc
[modify] https://crrev.com/809d8fb01773e476e122ad1739530caa3d02dfed/chrome/renderer/chrome_render_thread_observer.h
[modify] https://crrev.com/809d8fb01773e476e122ad1739530caa3d02dfed/chrome/renderer/url_loader_throttle_provider_impl.cc

Sign in to add a comment