New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 897985 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

shill: net/ source files should not have to be specified twice in the build

Project Member Reported by akhouderchah@chromium.org, Oct 23

Issue description

CL:947318 modifies shill's build such that net/ source files are built twice--once for shill, and once for a shared DLL using different compilation flags. It is inconvenient to insist that developers remember that newly-added net/ source files must be specified twice in the build file, however. Shill's BUILD.gn should be changed to only require net/ source files to be specified once.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b663f56890377be9c3045368351007711d4ab832

commit b663f56890377be9c3045368351007711d4ab832
Author: Alex Khouderchah <akhouderchah@chromium.org>
Date: Tue Oct 23 20:01:38 2018

shill: Only list net/ source files once in BUILD.gn

CL:947318 modifies shill's build such that net/ source files are built
twice--once for shill, and once for a shared DLL using different
compilation flags. It is inconvenient to insist that developers remember
that newly-added net/ source files must be specified twice in the build
file, however. This change instead places the net source files in a
"net_sources" list that is used by both targets.

BUG= chromium:897985 
TEST=`cros_workon_make --board ${BOARD} shill --test` succeeds.
     Adding a non-existent source file to net_sources causes the build
     to fail.

Change-Id: I6da7f1e46d36dcd29a7e93fc4750a24deda90ebe
Reviewed-on: https://chromium-review.googlesource.com/1295569
Commit-Ready: Alex Khouderchah <akhouderchah@chromium.org>
Tested-by: Alex Khouderchah <akhouderchah@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/b663f56890377be9c3045368351007711d4ab832/shill/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment