Move "Windows deterministic" bot to main waterfall |
|||
Issue descriptionAs of today, builds on Windows are deterministic for almost all binaries (roughly the same small number of exceptions as on linux). To make sure it stays that way, we should move the bot that checks this from FYI to the main waterfall. While at it, we should probably rename it from "Windows deterministic" to "Deterministic Windows" to match the "Deterministic Linux" waterfall on the main waterfall.
,
Oct 23
If you're going to rename bots, you should rename them to match the (admittedly fairly incomplete) naming standard at bit.ly/chromium-build-naming, which would suggest renaming it to something like win-deterministic-rel (and linux-deterministic-rel). Moving to different waterfalls is certainly much easier in the luci/milo world, but not quite trivial, you still have to do several patches to land and renaming everything w/o breakage.
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/538e9529538ef3f9b73136fb34c87308aa91b76a commit 538e9529538ef3f9b73136fb34c87308aa91b76a Author: Nico Weber <thakis@chromium.org> Date: Wed Oct 24 01:02:54 2018 Move 'Windows deterministic' from FYI to the main waterfall. Bug: 897980 ,330260 Change-Id: I71bb304c6398484d5af5a981fdbc09314d69dd22 Reviewed-on: https://chromium-review.googlesource.com/c/1295272 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602198} [modify] https://crrev.com/538e9529538ef3f9b73136fb34c87308aa91b76a/infra/config/global/luci-milo.cfg [modify] https://crrev.com/538e9529538ef3f9b73136fb34c87308aa91b76a/tools/mb/mb_config.pyl
,
Oct 24
Looks like this Just Worked :-)
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe0e62f5d70b9c0c9bbf60265498c66cfbb4ca60 commit fe0e62f5d70b9c0c9bbf60265498c66cfbb4ca60 Author: Nico Weber <thakis@chromium.org> Date: Wed Oct 24 10:10:10 2018 Move "Windows deterministic" to chromium.win in cr-buildbucket.cfg too https://chromium-review.googlesource.com/c/1295272 moved the bot on the console and updated mb_config.pyl. But once the bot had synced in the mb_config.pyl change, it started failing with lookup GN args Failed to extract GN args from output of "mb lookup" The lookup step still passes in `-m chromium.fyi`, and due to the mb_config.pyl change that no longer works. My best guess is that the mastername comes from the cr-buildbucket.cfg file, so change the master here too. (Seems like a nice thing to do in general.) TBR=dpranke Bug: 897980 Change-Id: I95fe0b7470ec39eb8ebfd0dc5a57980d598b0e46 Reviewed-on: https://chromium-review.googlesource.com/c/1297262 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602285} [modify] https://crrev.com/fe0e62f5d70b9c0c9bbf60265498c66cfbb4ca60/infra/config/global/cr-buildbucket.cfg
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1917dd47a5fed7edf77bfa80ed3e3dccf17b693 commit c1917dd47a5fed7edf77bfa80ed3e3dccf17b693 Author: Marc Treib <treib@chromium.org> Date: Wed Oct 24 11:35:53 2018 Revert "Move 'Windows deterministic' from FYI to the main waterfall." This reverts commit 538e9529538ef3f9b73136fb34c87308aa91b76a. Reason for revert: "Windows deterministic" has been consistently failing on the main waterfall: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Windows%20deterministic First failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Windows%20deterministic/10487 Error message from the lookup_GN_args step looks like this: Traceback (most recent call last): File "C:\b\swarming\w\ir\kitchen-workdir\src\tools\mb\mb.py", line 63, in Main ret = self.args.func() File "C:\b\swarming\w\ir\kitchen-workdir\src\tools\mb\mb.py", line 332, in CmdLookup vals = self.Lookup() File "C:\b\swarming\w\ir\kitchen-workdir\src\tools\mb\mb.py", line 614, in Lookup config = self.ConfigFromArgs() File "C:\b\swarming\w\ir\kitchen-workdir\src\tools\mb\mb.py", line 696, in ConfigFromArgs (self.args.builder, self.args.master, self.args.config_file)) MBErr: Builder name "Windows deterministic" not found under masters[chromium.fyi] in "C:\b\swarming\w\ir\kitchen-workdir\src\tools\mb\mb_config.pyl" Original change's description: > Move 'Windows deterministic' from FYI to the main waterfall. > > Bug: 897980 ,330260 > Change-Id: I71bb304c6398484d5af5a981fdbc09314d69dd22 > Reviewed-on: https://chromium-review.googlesource.com/c/1295272 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602198} TBR=thakis@chromium.org,dpranke@chromium.org,martiniss@chromium.org Change-Id: Ib9aff7c076f1f0e3192788f10da80036b4262ed1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897980 , 330260 Reviewed-on: https://chromium-review.googlesource.com/c/1297139 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#602297} [modify] https://crrev.com/c1917dd47a5fed7edf77bfa80ed3e3dccf17b693/infra/config/global/luci-milo.cfg [modify] https://crrev.com/c1917dd47a5fed7edf77bfa80ed3e3dccf17b693/tools/mb/mb_config.pyl
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/702055f4e67df682129a726ec29291ecbd24c4c3 commit 702055f4e67df682129a726ec29291ecbd24c4c3 Author: Nico Weber <thakis@chromium.org> Date: Wed Oct 24 11:50:22 2018 Reland "Move 'Windows deterministic' from FYI to the main waterfall." This is a reland of 538e9529538ef3f9b73136fb34c87308aa91b76a It was reverted at https://chromium-review.googlesource.com/c/1297139 but the problem has already been fixed in https://chromium-review.googlesource.com/c/1297262. Original change's description: > Move 'Windows deterministic' from FYI to the main waterfall. > > Bug: 897980 ,330260 > Change-Id: I71bb304c6398484d5af5a981fdbc09314d69dd22 > Reviewed-on: https://chromium-review.googlesource.com/c/1295272 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602198} TBR=thakis@chromium.org,dpranke@chromium.org,martiniss@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897980 , 330260 Change-Id: I03a1784ea48bcaa6567d4ec2dd482d218d0f4740 Reviewed-on: https://chromium-review.googlesource.com/c/1297426 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#602303} [modify] https://crrev.com/702055f4e67df682129a726ec29291ecbd24c4c3/infra/config/global/luci-milo.cfg [modify] https://crrev.com/702055f4e67df682129a726ec29291ecbd24c4c3/tools/mb/mb_config.pyl |
|||
►
Sign in to add a comment |
|||
Comment 1 by thakis@chromium.org
, Oct 22