Issue metadata
Sign in to add a comment
|
chromium_commands.dex.jar is not deterministic |
||||||||||||||||||||||
Issue descriptionWe have a bot that checks that our build is deterministic. It builds all tests, then copies the build dir elsewhere, builds everything again, and then compares outputs. Outputs should be the same both times. The android build used to be 100% deterministic; now we have 3 small regressions. For this bug: lib.java/chromium_commands.dex.jar fails this test. Need to figure out why and fix.
,
Oct 22
Relatively small diff:
lib.java/chromium_commands.dex.jar : DIFFERENT (unexpected): 4 out of 3152 bytes are different (0.13%)
0x0 : 504b03040a0000080000415d564d1ff1fd47d80b0000d80b00000b000000636c 'PK........A]VM...G............cl'
504b03040a00000800005367564d1ff1fd47d80b0000d80b00000b000000636c 'PK........SgVM...G............cl'
^^^ ^^
0xc00 : 00504b01020a000a0000080000415d564d1ff1fd47d80b0000d80b00000b0000 '.PK..........A]VM...G...........'
00504b01020a000a00000800005367564d1ff1fd47d80b0000d80b00000b0000 '.PK..........SgVM...G...........'
^^^
(https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8931942708020839696/+/steps/compare_build_artifacts/0/stdout)
Maybe just zip timestamp headers; might need something like https://chromium-review.googlesource.com/c/chromium/src/+/1163349
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d774d9ef69d1284a601a122b75f147377b475a5 commit 8d774d9ef69d1284a601a122b75f147377b475a5 Author: Nico Weber <thakis@chromium.org> Date: Mon Oct 22 23:52:46 2018 Update deterministic build whitelist for android and mac a bit. Both bots are red; this improves things a bit (but likely not completely, I only looked at a handful recent builds each). Bug: 897969 , 897970 ,330262 Change-Id: I2c399774175e57285eafc1c0de99a6f893e62fea Reviewed-on: https://chromium-review.googlesource.com/c/1295270 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601785} [modify] https://crrev.com/8d774d9ef69d1284a601a122b75f147377b475a5/tools/determinism/deterministic_build_whitelist.pyl
,
Nov 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65f7c38e0aacaa4b19685ce6706d9d84bf101c8f commit 65f7c38e0aacaa4b19685ce6706d9d84bf101c8f Author: Andrew Grieve <agrieve@chromium.org> Date: Fri Nov 23 18:47:10 2018 Remove compile_commands.dex.jar from deterministic_build_whitelist.pyl I spot checked the last 10 builds on: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Android And it's been fine. I also checked locally that the .jar file has a hermetic timestamp for the file entry (via unzip -lv) Bug: 897970 Change-Id: Ifd38c3b7c197fbf2175cf16f462d56be31d1da2d Reviewed-on: https://chromium-review.googlesource.com/c/1349674 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610653} [modify] https://crrev.com/65f7c38e0aacaa4b19685ce6706d9d84bf101c8f/tools/determinism/deterministic_build_whitelist.pyl
,
Nov 24
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30327733e35d9d76f94161a010b70ab39fa59e53 commit 30327733e35d9d76f94161a010b70ab39fa59e53 Author: Nico Weber <thakis@chromium.org> Date: Tue Nov 27 15:05:33 2018 android deterministic: Remove remaining whitelist entries. Looks like https://chromium-review.googlesource.com/c/chromium/src/+/1349854 fixed these too. Bug: 897970 , 897969 Change-Id: I09dac10a533511fbab3d49e9c0055ebc7b507f2d Reviewed-on: https://chromium-review.googlesource.com/c/1350190 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#611109} [modify] https://crrev.com/30327733e35d9d76f94161a010b70ab39fa59e53/tools/determinism/deterministic_build_whitelist.pyl |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jbudorick@chromium.org
, Oct 22