New issue
Advanced search Search tips

Issue 897968 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 25
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 897260

Blocking:
issue 640365



Sign in to add a comment

mash: shelf doesn't auto-show when mouse hovers bottom of screen in immersive fullscreen

Project Member Reported by est...@chromium.org, Oct 22

Issue description

1. put a window in immersive fullscreen.
2. hover bottom of screen.
3. in classic Ash, shelf reveals
4. in Mash (single or multi process), nothing happens.
 
Blockedon: 897260
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/828cedfdbb8333005fd1caad46ffc24ab53507e3

commit 828cedfdbb8333005fd1caad46ffc24ab53507e3
Author: Evan Stade <estade@chromium.org>
Date: Tue Oct 23 00:52:03 2018

Mash: Make Chrome update correct window's properties for immersive.

This makes ShelfLayoutManager::UpdateVisibilityState correctly update
state to SHELF_AUTO_HIDE, which triggers Shelf::AutoHideEventHandler,
which already works without updates.

Bug:  897968 

Change-Id: Id2e5f785dbf24a0999088b13fe4971ee6758e32e
Reviewed-on: https://chromium-review.googlesource.com/c/1295176
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601809}
[modify] https://crrev.com/828cedfdbb8333005fd1caad46ffc24ab53507e3/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/828cedfdbb8333005fd1caad46ffc24ab53507e3/chrome/browser/ui/views/frame/immersive_context_mus.cc

Status: Fixed (was: Started)

Sign in to add a comment