New issue
Advanced search Search tips

Issue 897965 link

Starred by 2 users
Status: Fixed
Owner:
jsaul@google.com
Closed: Oct 24
Cc:
dennishu@google.com
annelim@google.com
dlkumar@google.com
se...@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Merge request for Project Traffic Light

Project Member Reported by jsaul@google.com, Oct 22 
Requesting M71 merge for the following two CLs for Project Traffic Light:

https://chromium-review.googlesource.com/c/chromium/src/+/1294429 - Add strikes when credit card save ignored/denied/fails
https://chromium-review.googlesource.com/c/chromium/src/+/1277842 - Clearing Autofill browsing data clears the Autofill StrikeDatabase

These changes are flag-protected, self-contained to Autofill, and have been manually tested locally.  I'll follow up when Canary includes 1294429 so I can test there as well.

Comment 1 by jsaul@google.com, Oct 23 

Canary test in 72.0.3589.0 successful.

Comment 2 by jsaul@google.com, Oct 23

Labels: M-71
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 23

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by jsaul@google.com, Oct 23

Cc: se...@chromium.org
Hi Seb, as we're likely fast-tracking this, would you mind merging these CLs?
Probably this order, since it's the order they landed in:
https://chromium-review.googlesource.com/c/chromium/src/+/1277842
Then:
https://chromium-review.googlesource.com/c/chromium/src/+/1294429
Thanks!

Comment 5 by gov...@chromium.org, Oct 24 

Pls merge you change to M71 branch 3578 ASAP  so we can pick it up for next week beta release. Thank you.

Comment 7 by se...@chromium.org, Oct 24

Labels: -Merge-Approved-71 Merge-Merged

Comment 8 by gov...@chromium.org, Oct 24

Labels: -Merge-Merged merge-merged-3578

Comment 9 by jsaul@google.com, Oct 24

Status: Fixed (was: Assigned)
Thank you Seb!
►

Sign in to add a comment