New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 897957 link

Starred by 2 users
Status: Fixed
Owner:
█ jrw@chromium.org
Last visit > 30 days ago
Closed: Oct 30
Cc:
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Chrome crashes by stopping and starting casting.

Project Member Reported by dbbrooks@chromium.org, Oct 22 
Chrome Version: 72.0.3588.1
OS: Win10
MR: 7218.1022.0.0

What steps will reproduce the problem?
(1) Stop and start casting multiple times in a row from the same tab.
    - It doesn't have to be super fast, but a little quickly.
    - It's not always that easy to repro. Some times, switching the cast receiver caused it to repro. Other times, it seemed like opening and closing the dialog played a part in the repro. 

Chrome crashes at some point. I first notices this when testing the Presentation api, then was able to repro it casting a tab as well. I was able to crash it many many times.

Crash ID's:
a0bfdaec3fb3556f
82e189c99d50263f
99284cf8dfcf7296
3aa0027a08e534d8
3a4d7236d70d6663
4b6aa1a5dfc08454

Comment 1 by mfo...@chromium.org, Oct 23

Labels: -Pri-2 -FoundIn-71 Target-72 M-72 FoundIn-72 Pri-1
Owner: jrw@chromium.org
Status: Assigned (was: Untriaged)
jrw@, the first crash was in code added in https://chromium-review.googlesource.com/c/1281878.  PTAL.  If the fix isn't obvious, then reverting the patch is always a safe choice.

Also updating the labels to M72.

Comment 2 by mfo...@chromium.org, Oct 23

Components: -Blink>PresentationAPI -Internals>Cast Internals>Cast>UI

Comment 3 by jrw@chromium.org, Oct 23 

I put up a CL which I believe will fix this issue, but I can't be 100% certain, because I've been unable to reproduce the problem so far.

Comment 4 by jrw@chromium.org, Oct 26 

I found a consistent repro and confirmed the fix. (For the record, the problem happens when the receiver status is the empty string, which causes the "subtitle" UX element not to be created.)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d01500795bf0bb1e99acd9a9274d1521d05098c6

commit d01500795bf0bb1e99acd9a9274d1521d05098c6
Author: John Williams <jrw@google.com>
Date: Sat Oct 27 01:03:21 2018

Added check to prevent crash when subtitle() == nullptr.

Bug:  897957 
Change-Id: I2a40aa56067b2567ace74884cf62898e8c87f883
Reviewed-on: https://chromium-review.googlesource.com/c/1297631
Commit-Queue: John Williams <jrw@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603273}
[modify] https://crrev.com/d01500795bf0bb1e99acd9a9274d1521d05098c6/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc

Comment 6 by jrw@chromium.org, Oct 30

Status: Fixed (was: Assigned)

Comment 7 by taku...@chromium.org, Nov 1 

The fix landed in 72.0.3593.0 and there haven't been crashes after that version.
►

Sign in to add a comment