YouTube AV1 playback isn't triggering disable of video decode in the background |
||||||||||
Issue descriptionYouTube is seeing rebuffering in the background which shouldn't happen since we disable the video decoder in the background. A quick check shows that the feature is not kicking in for AV1 playbacks, the Media.Video.KeyframeDistance histogram shows <5s key frames, but haven't verified is reflective of the actual key frame distances yet. https://www.youtube.com/watch?v=2nXYbGmF3_Q is what I tested.
,
Oct 22
Keyframe distance for that video is 5.33s: [1:18:1022/154516.010190:ERROR:decoder_stream_traits.cc(200)] OnDecode: 5.33867 [1:18:1022/154521.320860:ERROR:decoder_stream_traits.cc(200)] OnDecode: 5.33867 [1:18:1022/154526.654299:ERROR:decoder_stream_traits.cc(200)] OnDecode: 5.33867 [1:18:1022/154531.987924:ERROR:decoder_stream_traits.cc(200)] OnDecode: 5.33867
,
Oct 23
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/456808a6f75db746452b7e3c825a7c808fb74fe9 commit 456808a6f75db746452b7e3c825a7c808fb74fe9 Author: Dale Curtis <dalecurtis@chromium.org> Date: Tue Oct 23 17:50:21 2018 Expand keyframe distance to 5.5 seconds. Essentially the same as ~5 seconds after rounding to seconds. BUG= 897954 TEST=updated tests. R=tmathmeyer Change-Id: Id280d2c225b85f02c2f559ccbeacbb3d34569e5e Reviewed-on: https://chromium-review.googlesource.com/c/1295269 Reviewed-by: Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602013} [modify] https://crrev.com/456808a6f75db746452b7e3c825a7c808fb74fe9/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/456808a6f75db746452b7e3c825a7c808fb74fe9/media/blink/webmediaplayer_impl.h [modify] https://crrev.com/456808a6f75db746452b7e3c825a7c808fb74fe9/media/blink/webmediaplayer_impl_unittest.cc
,
Oct 24
Will let soak a couple days on canary and then request merge.
,
Oct 29
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Oct 29
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Oct 29
No real changes in average, so this looks good to merge: https://uma.googleplex.com/p/chrome/timeline_v2/?sid=30f36577b3ed6b35e5cb05d8c8523a30
,
Oct 29
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 30
Approving merge to M71 branch 3578 based on comment #8. Pls merge before 1:00 PM PT tomorrow so we can pick it up for this week beta release. Thank you.
,
Oct 30
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec3fa3dbe8b0ea0857e7c63b1b57d042484bd18a commit ec3fa3dbe8b0ea0857e7c63b1b57d042484bd18a Author: Dale Curtis <dalecurtis@chromium.org> Date: Tue Oct 30 16:56:34 2018 Expand keyframe distance to 5.5 seconds. Essentially the same as ~5 seconds after rounding to seconds. BUG= 897954 TEST=updated tests. R=​tmathmeyer Change-Id: Id280d2c225b85f02c2f559ccbeacbb3d34569e5e Reviewed-on: https://chromium-review.googlesource.com/c/1295269 Reviewed-by: Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602013}(cherry picked from commit 456808a6f75db746452b7e3c825a7c808fb74fe9) Reviewed-on: https://chromium-review.googlesource.com/c/1307993 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#402} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/ec3fa3dbe8b0ea0857e7c63b1b57d042484bd18a/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/ec3fa3dbe8b0ea0857e7c63b1b57d042484bd18a/media/blink/webmediaplayer_impl.h [modify] https://crrev.com/ec3fa3dbe8b0ea0857e7c63b1b57d042484bd18a/media/blink/webmediaplayer_impl_unittest.cc
,
Oct 30
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec3fa3dbe8b0ea0857e7c63b1b57d042484bd18a Commit: ec3fa3dbe8b0ea0857e7c63b1b57d042484bd18a Author: dalecurtis@chromium.org Commiter: dalecurtis@chromium.org Date: 2018-10-30 16:56:34 +0000 UTC Expand keyframe distance to 5.5 seconds. Essentially the same as ~5 seconds after rounding to seconds. BUG= 897954 TEST=updated tests. R=​tmathmeyer Change-Id: Id280d2c225b85f02c2f559ccbeacbb3d34569e5e Reviewed-on: https://chromium-review.googlesource.com/c/1295269 Reviewed-by: Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602013}(cherry picked from commit 456808a6f75db746452b7e3c825a7c808fb74fe9) Reviewed-on: https://chromium-review.googlesource.com/c/1307993 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#402} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 1
dalecurtis@ Please provide verification steps for closing the issue. Thanks! |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by dalecur...@chromium.org
, Oct 22