Also on the bots https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8931927390191358720/+/steps/sizes/0/stdout

(I _think_ debugallocation_shim.cc is also new(ish), but I'm not sure)

Thanks for taking this one!

re: debugallocation_shim.cc - it looks vaguely familiar, but I'm not certain either.

I sent out https://chromium-review.googlesource.com/c/chromium/src/+/1294842 for this one.

Thanks for fixing, thestig!

thakis: I think we should add the SI check to one of the bots that runs on the CQ.  The check takes only a few seconds, so should we just make it part of the build?  There are already some checks that run when building the Linux packages.  Maybe we could add it there?  (and in the equivalent mac packaging stuff)

I agree that that'd be nice; that's  issue 110002 . After your recent work it's probably much easier to do than it used to be :-)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5de6556044499ff9dcaf128e86a94d6c9afe6bf5

commit 5de6556044499ff9dcaf128e86a94d6c9afe6bf5
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Oct 23 00:22:57 2018

Get rid of a static initializer in AXPlatformNodeAuraLinux.

BUG= 897920 

Change-Id: I6ff877d4059874e5066baa902aa682401050cabb
Reviewed-on: https://chromium-review.googlesource.com/c/1294842
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601796}
[modify] https://crrev.com/5de6556044499ff9dcaf128e86a94d6c9afe6bf5/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/5de6556044499ff9dcaf128e86a94d6c9afe6bf5/ui/accessibility/platform/ax_platform_node_auralinux.h

See sizes step on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-rel/8297 vs. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-rel/8298

# Found 28 static initializers in 5 files.

vs.

# Found 24 static initializers in 4 files.

Also, the SIs in debugallocation_shim.cc existed as of 2 months ago: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-rel/2500

Are you going to lower the expectation in src/infra/scripts/legacy/scripts/slave/chromium/sizes.py or do you want me to do that?

I can do it.

Actually, no we should not lower it yet. Official Chrome builds still has 5.