New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 897916 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 911720



Sign in to add a comment

Chrome://settings/network not getting updated.

Project Member Reported by jmuppala@chromium.org, Oct 22

Issue description

Chrome Version: <From about:version: Google Chrome 71.0.3578.18>
Chrome OS Version: <From about:version: Platform 11151.9.0>
Chrome OS Platform: <Nocturne>


Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1)Connect to a Wifi network
(2)Suspend the device for 20-30min
(3)Resume and verify wifi network connected.
(4)chrome://settings/network shows the connected network.
(5)connect to a different wifi network through uber tray.
(6)chrome://settings/network does not update the new connected network.
(7)Clicking refresh button on the keyboard now shows the new connected network.

Expected Result:
chrome://settings/Network should update as soon as you connect to a different network.
Actual Result:
Wont display the new network until refreshed.

Please see screenshot attached.

Will update feeback report once available.


 
Labels: -Pri-3 Pri-1
Cc: kirtika@chromium.org
Cc: steve...@chromium.org
Cc: jordynass@chromium.org
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)
It looks like this may have been broken for a while. I will make some time to investigate soon.

Steven,
What dbus messages does the UI use in this case? Is it worth adding an autotest that checks that shill gives the correct responses or a unit-test in Chrome that fakes network changes and adds an EXPECT_CALL for shill dbus calls?

I don't think the problem is that low level, I think it is just that the page itself is not listening for the correct event. We do have tests for the model/conenctor code (NetworkHandler).


Labels: Needs-Feedback
I can't reproduce this on ToT, and I can't reproduce this on a pixel 2 @ 71.0.3578.8, skipping the suspend/resume. (I think of why suspend/resume should have any effect). I'll try after resuming after lunch.

Could you re-verify this:
a) On a different device
b) With a more recent 71 build

Also please file a feedback report that includes the names of the networks connected to/from.

Able to consistently repro this on Nocturne - 11151.17.0, 71.0.3578.27.

Feedback report@
https://listnr.corp.google.com/report/85754088219


Could not repro on Coral device, will update after more testing.

networks-not-updated.png
469 KB View Download
Are the versions the same with Nocturne and Coral? It seems odd that this would be device specific.

This did not reproduce for me on my Pixel 2 after lunch.

The feedback report definitely shows that we are triggering a notification.

Can you inspect the Settings JS console (ctrl-shift-c) to see if there is an error there?

both devices have the same version 71.0.3578.27.

as soon as i hit inspect on the chrome://settings/internet page, wifi network got updated.


Were there any console errors?

That in itself is a bit suspicious. I wonder if we are doing something special on nocturne that would interfere with updating page content for unfocused windows?

Did the console show any error messages in the console?

Could you try the following?
* Navigate to the WiFi subpage and see if that updates.
* Navigate to the detail page for the connected network and see whether that updates.

Yes, the console shows these errors:

[Deprecation] HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.
polymer-micro-extracted.js:442 [Deprecation] document.registerElement is deprecated and will be removed in M73, around March 2019. Please use window.customElements.define instead. See https://www.chromestatus.com/features/4642138092470272 for more details.
(anonymous) @ polymer-micro-extracted.js:442
polymer-mini-extracted.js:2083 [Deprecation] Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details.
_createLocalRoot @ polymer-mini-extracted.js:2083


Wifi subpage and detail page are updated, it is the chrome:settings/network on the browser that does not. It mostly happens when the notifications is turned off on the uber tray. Please see attached video.
Nocturne-chrome-settings.MOV
2.5 MB View Download
<Bulk edit> Reminder M71 Stable is approaching. Please review this bug and assess if this is indeed a RBS. If not, please remove the RBS label. If so, please make sure any planned work will be tested in Beta and verified before the Stable date. Thanks
Labels: Hotlist-ConOps-CrOS
<BULK EDIT> Reminder we nearinf M71 Stable. Please review this issue and update with your plan on next actions. Thanks.
I'll try to reproduce this again today, but this doesn't seem like a P1/RBS issue to me.

@stevenjb - Can you please provide an update for this issue? This is marked RBS and stable is approaching soon. Thanks

Labels: -Pri-1 -ReleaseBlock-Stable -M-71 M-73 Pri-2
I have been unable to reproduce this I still can't reproduce this. It really is not RBS, removing that label and moving to 73 for further investigation.

Re: comment #13, could you elaborate on "It mostly happens when the notifications is turned off on the uber tray."? Also, could you verify this on the latest 72?

Whenever I could repro this issue before I noticed that it was when i set the   notifications to ->"do not disturb" on the uber tray. I am not sure if they are related though.


I am not able to reproduce this on M72-11316.0.0.
Status: WontFix (was: Assigned)
I tried again the other day and couldn't reproduce it either. Closing this for now. If you see it again >= 72, please re-open. Isolating as many variables (e.g. 'do not disturb' setting) will help, although I'd be a bit surprised if that was related.

More likely something was causing the Settings page not to receive the event or not to update, either a scheduling issue or a bug in the JS. Opening the dev console for the Settings page after this happens and looking for errors (in red) would also help.

Thanks!

sure. will lookout for this in M72.
Status: Assigned (was: WontFix)
Seeing this issue in M73-11334.0.0, 73.0.3628.0 on Santa/Coral.

chrome://settings/network does not list the new wifi connection. 
Screenshot 2018-12-03 at 1.59.48 PM.png
100 KB View Download
Could you try to produce a reliable repro? Also, could you:

* Focus the Settings page - does the network update?
* Show the JS console for the Settings page (ctrl-shift-j).

1)connect to a new wifi network from uber tray, uber tray updated to the new network
2)chrome://settings/network -> not updated to the new network
3)chrome://settings/network -> wifi detailed view/subpage -> updated to the new network.
4)JS console for settings page shows a uncaught RangeError, please see attached screenshot.


coral-chrome-settings.jpg
3.8 MB View Download
js-console.jpg
5.3 MB View Download
Blockedon: 911720
Thanks for the repro. I have not been able to reproduce this, but I think that the JS console output may be exposing the root cause: The Settings page JS is failing and no longer updating. IIRC reloading the Settings page fixes the issue?

Filed issue 911720 to track the JS error.

jmuppala@ - Do you have a custom profile image set up? I haven't been able to reproduce that JS console error, and they only way I imagine it could be triggered is with an unexpected or corrupt profile image. Was this produced with a test account that I could try logging in with?

Hi , no just a test account, pinging you the credentials.
Labels: M-71
Seeing this issue on Rabbid/Coral M71- 11151.59.2, 71.0.3578.94.

No errors on the JS console on chrome://settings page. But as before chrome://settings not updating the wifi status, the wifi detailed  view is updated.

Sign in to add a comment