New issue
Advanced search Search tips

Issue 897900 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 24
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Divider position of splitview should based on work area bounds

Project Member Reported by minch@chromium.org, Oct 22

Issue description

What steps will reproduce the problem?
(1) Enable docked magnifier and switch to tablet mode.
(2) Rotate to portrait secondary, snap one window to splitview, the divider is in the middle by default.
(3) Rotate the screen to landscape primary.

What is the expected result?
The divider should still in the middle.

What happens instead?
The divider is in two-third position.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca9a3f3e08147ccbd0b290073b4c7380b3a06420

commit ca9a3f3e08147ccbd0b290073b4c7380b3a06420
Author: Min Chen <minch@google.com>
Date: Wed Oct 24 16:34:48 2018

Update split view divider position on work area bounds.

Work area is not always starts from the top of the display, e.g, docked
magnifier will put a view port window at the top area of the display.
This will cause that in portrait screen orientation, the height of the
work area is not always larger than the width of the work area. This cl
tried to fix this by updating the divider position on
|divider_closest_ratio_| instead on relying on the longer side of the
work area.
This cl also fixed the wrong bounds of the preview area, which was set
in its own view coordinate. So should special consider the case that
work area is not from the top of the display too.

Bug: 866680,  897900 
Change-Id: I86a98aee52ecbd706385cda0a639e5182997914b
Reviewed-on: https://chromium-review.googlesource.com/c/1292833
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602364}
[modify] https://crrev.com/ca9a3f3e08147ccbd0b290073b4c7380b3a06420/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/ca9a3f3e08147ccbd0b290073b4c7380b3a06420/ash/wm/splitview/split_view_controller.h
[modify] https://crrev.com/ca9a3f3e08147ccbd0b290073b4c7380b3a06420/ash/wm/splitview/split_view_controller_unittest.cc
[modify] https://crrev.com/ca9a3f3e08147ccbd0b290073b4c7380b3a06420/ash/wm/splitview/split_view_drag_indicators.cc

Status: Fixed (was: Started)

Sign in to add a comment