New issue
Advanced search Search tips

Issue 897892 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 23
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 883032



Sign in to add a comment

Unnecessary Layers in App List causes jank

Project Member Reported by ginko@chromium.org, Oct 22

Issue description

blocking bug
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/659144bb782ed7fcf8f352da3accaec0228e184c

commit 659144bb782ed7fcf8f352da3accaec0228e184c
Author: Kevin Strohbehn <ginko@google.com>
Date: Tue Oct 23 22:34:03 2018

Removes unnecessary layers to improve FPS in launcher

Bug:  897892 
Change-Id: I0f1412fba8ee32d998f7166a90c1d4ee7d78b70b
Reviewed-on: https://chromium-review.googlesource.com/c/1292891
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602143}
[modify] https://crrev.com/659144bb782ed7fcf8f352da3accaec0228e184c/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/659144bb782ed7fcf8f352da3accaec0228e184c/ash/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/659144bb782ed7fcf8f352da3accaec0228e184c/ash/app_list/views/app_list_item_view.cc
[modify] https://crrev.com/659144bb782ed7fcf8f352da3accaec0228e184c/ash/app_list/views/app_list_main_view.cc
[modify] https://crrev.com/659144bb782ed7fcf8f352da3accaec0228e184c/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/659144bb782ed7fcf8f352da3accaec0228e184c/ash/app_list/views/contents_view.cc
[modify] https://crrev.com/659144bb782ed7fcf8f352da3accaec0228e184c/ash/app_list/views/contents_view.h
[modify] https://crrev.com/659144bb782ed7fcf8f352da3accaec0228e184c/ash/wallpaper/wallpaper_view.cc

Status: Fixed (was: Untriaged)
Labels: Merge-Request-71
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 24

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 26

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4efaacdb8e2ae912330bef9ddaa7d9786e58b351

commit 4efaacdb8e2ae912330bef9ddaa7d9786e58b351
Author: Kevin Strohbehn <ginko@google.com>
Date: Fri Oct 26 18:19:12 2018

Merge M71: Removes unnecessary layers to improve FPS in launcher

Bug:  897892 
Change-Id: I0f1412fba8ee32d998f7166a90c1d4ee7d78b70b
Reviewed-on: https://chromium-review.googlesource.com/c/1292891
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602143}(cherry picked from commit 7544927ece4358db0c3600dc9147a5a683cf3a87)
Reviewed-on: https://chromium-review.googlesource.com/c/1299960
Cr-Commit-Position: refs/branch-heads/3578@{#348}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/4efaacdb8e2ae912330bef9ddaa7d9786e58b351/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/4efaacdb8e2ae912330bef9ddaa7d9786e58b351/ash/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/4efaacdb8e2ae912330bef9ddaa7d9786e58b351/ash/app_list/views/app_list_item_view.cc
[modify] https://crrev.com/4efaacdb8e2ae912330bef9ddaa7d9786e58b351/ash/app_list/views/app_list_main_view.cc
[modify] https://crrev.com/4efaacdb8e2ae912330bef9ddaa7d9786e58b351/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/4efaacdb8e2ae912330bef9ddaa7d9786e58b351/ash/app_list/views/contents_view.cc
[modify] https://crrev.com/4efaacdb8e2ae912330bef9ddaa7d9786e58b351/ash/app_list/views/contents_view.h
[modify] https://crrev.com/4efaacdb8e2ae912330bef9ddaa7d9786e58b351/ash/wallpaper/wallpaper_view.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/4efaacdb8e2ae912330bef9ddaa7d9786e58b351

Commit: 4efaacdb8e2ae912330bef9ddaa7d9786e58b351
Author: ginko@google.com
Commiter: weidongg@chromium.org
Date: 2018-10-26 18:19:12 +0000 UTC

Merge M71: Removes unnecessary layers to improve FPS in launcher

Bug:  897892 
Change-Id: I0f1412fba8ee32d998f7166a90c1d4ee7d78b70b
Reviewed-on: https://chromium-review.googlesource.com/c/1292891
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602143}(cherry picked from commit 7544927ece4358db0c3600dc9147a5a683cf3a87)
Reviewed-on: https://chromium-review.googlesource.com/c/1299960
Cr-Commit-Position: refs/branch-heads/3578@{#348}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment