We use 'The DLC' or 'A DLC' throughout dlcservice and update_engine which is grammerly wrong. Let's replace them with 'The DLC module' and 'A DLC module'.
+1
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/e34c6e90546efef7eb5678ddac46d27c815db104 commit e34c6e90546efef7eb5678ddac46d27c815db104 Author: Xiaochu Liu <xiaochu@chromium.org> Date: Tue Nov 27 04:31:25 2018 dlcservice: fix the english Fix the english for accuracy in d-bus config file. BUG= chromium:897882 TEST=None Change-Id: Ib44ef219e6176b31815668872811cd15dc5f2c8b Reviewed-on: https://chromium-review.googlesource.com/1351392 Commit-Ready: Xiaochu Liu <xiaochu@chromium.org> Tested-by: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/e34c6e90546efef7eb5678ddac46d27c815db104/dlcservice/dbus_adaptors/org.chromium.DlcServiceInterface.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/78dc7f5bdb22edbdb1a564a31345670518873094 commit 78dc7f5bdb22edbdb1a564a31345670518873094 Author: Xiaochu Liu <xiaochu@chromium.org> Date: Wed Nov 28 03:14:13 2018 imageloader: fix the english Fix the english for accuracy regarding DLC. BUG= chromium:897882 TEST=None Change-Id: I75c8ba59d600b7be4bb1c61fab505d75223baecf Reviewed-on: https://chromium-review.googlesource.com/1351397 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> [modify] https://crrev.com/78dc7f5bdb22edbdb1a564a31345670518873094/imageloader/imageloader_impl.h [modify] https://crrev.com/78dc7f5bdb22edbdb1a564a31345670518873094/imageloader/dbus_adaptors/org.chromium.ImageLoaderInterface.xml [modify] https://crrev.com/78dc7f5bdb22edbdb1a564a31345670518873094/imageloader/dlc.h
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/update_engine/+/f53a5d361991d2deecf530577d53ebb0b35b722d commit f53a5d361991d2deecf530577d53ebb0b35b722d Author: Xiaochu Liu <xiaochu@chromium.org> Date: Wed Nov 28 03:14:00 2018 update_engine: fix english Fix the english for accuracy regarding DLC. BUG= chromium:897882 TEST=None Change-Id: I72ab9ecb7903bb5fb35597222cd7c8b1f4244cfc Reviewed-on: https://chromium-review.googlesource.com/1351359 Commit-Ready: Xiaochu Liu <xiaochu@chromium.org> Tested-by: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by: Amin Hassani <ahassani@chromium.org> [modify] https://crrev.com/f53a5d361991d2deecf530577d53ebb0b35b722d/update_attempter_unittest.cc [modify] https://crrev.com/f53a5d361991d2deecf530577d53ebb0b35b722d/omaha_request_params.h [modify] https://crrev.com/f53a5d361991d2deecf530577d53ebb0b35b722d/mock_update_attempter.h [modify] https://crrev.com/f53a5d361991d2deecf530577d53ebb0b35b722d/update_attempter.h [modify] https://crrev.com/f53a5d361991d2deecf530577d53ebb0b35b722d/boot_control_chromeos.cc [modify] https://crrev.com/f53a5d361991d2deecf530577d53ebb0b35b722d/omaha_request_action_unittest.cc [modify] https://crrev.com/f53a5d361991d2deecf530577d53ebb0b35b722d/common_service.h [modify] https://crrev.com/f53a5d361991d2deecf530577d53ebb0b35b722d/common_service.cc [modify] https://crrev.com/f53a5d361991d2deecf530577d53ebb0b35b722d/omaha_request_action.cc [modify] https://crrev.com/f53a5d361991d2deecf530577d53ebb0b35b722d/update_engine_client.cc [modify] https://crrev.com/f53a5d361991d2deecf530577d53ebb0b35b722d/dbus_service.cc [modify] https://crrev.com/f53a5d361991d2deecf530577d53ebb0b35b722d/omaha_request_params.cc [modify] https://crrev.com/f53a5d361991d2deecf530577d53ebb0b35b722d/update_attempter.cc [modify] https://crrev.com/f53a5d361991d2deecf530577d53ebb0b35b722d/client_library/client_dbus.h [modify] https://crrev.com/f53a5d361991d2deecf530577d53ebb0b35b722d/client_library/include/update_engine/client.h [modify] https://crrev.com/f53a5d361991d2deecf530577d53ebb0b35b722d/client_library/client_dbus.cc
Issue 905538 has been merged into this issue.
Comment 1 by ahass...@chromium.org
, Oct 22