Application icons are not great on Mac in the source picker |
||
Issue descriptionsrc/chrome/media/webrtc/window_icon_util_mac.mm::GetWindowIcon retuns too small icons and cutoff. It returns 32x32 icons and dpi is not taken into account. See the coming CL to fix that.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f86df0fc2d924173e8fa637b8f4d7955370fbe6 commit 1f86df0fc2d924173e8fa637b8f4d7955370fbe6 Author: Julien Isorce <julien.isorce@chromium.org> Date: Thu Oct 25 17:50:51 2018 Use larger icon for GetWindowIcon on Mac Default is 32x32. Ensure to use something closer to 128x128. Also fix the wrong width/height along the way by using CGImageGetWidth/CGImageGetHeight otherwise the icon appears cut off as DPI was not taken into account. Bug: 897873 Change-Id: Ib0973154730fc237690605a1fe4f366c83cfe750 Reviewed-on: https://chromium-review.googlesource.com/c/1294416 Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#602781} [modify] https://crrev.com/1f86df0fc2d924173e8fa637b8f4d7955370fbe6/chrome/browser/media/webrtc/window_icon_util_mac.mm
,
Nov 19
|
||
►
Sign in to add a comment |
||
Comment 1 by julien.isorce@chromium.org
, Oct 22