reduce number of layers in overview mode |
|||||||||||||
Issue descriptionLooks like we can reduce the number of layers in overview mode.
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4804851e053bb6d1b50a0147c346b28274aec27 commit d4804851e053bb6d1b50a0147c346b28274aec27 Author: Mitsuru Oshima <oshima@chromium.org> Date: Tue Oct 23 05:50:41 2018 Reduce layers in overview mode * Change ShieldWidget's layer to NOW_DRAWN because it's always transparent. * Remove layer on image_view/title_view * Create an layer for unsnappable lable on demand. Bug: 897870 Test: no functional change. Updated the unit test. Change-Id: I23093ade07bc943ad16572d2704b78b13883c3bd Reviewed-on: https://chromium-review.googlesource.com/c/1295335 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#601859} [modify] https://crrev.com/d4804851e053bb6d1b50a0147c346b28274aec27/ash/wm/overview/overview_utils.cc [modify] https://crrev.com/d4804851e053bb6d1b50a0147c346b28274aec27/ash/wm/overview/window_grid.cc [modify] https://crrev.com/d4804851e053bb6d1b50a0147c346b28274aec27/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/d4804851e053bb6d1b50a0147c346b28274aec27/ash/wm/overview/window_selector_unittest.cc
,
Oct 23
,
Oct 25
oops, fixing label.
,
Oct 31
,
Oct 31
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 31
Pls apply appropriate OSs label. Thank you.
,
Nov 1
oops sorry. done.
,
Nov 1
This is a fairly large change so late in the M71 lifecycle. Also, Per the M71 Branch Announcement: "Have your change checked into the trunk, and tested by you on either a Canary build or Dev channel release before asking for merge approval." Has this testing taken place? If so, results? If not, please test prior to the merge request. Thanks.
,
Nov 1
This was tested on canary 72.0.3593.0.
,
Nov 1
This is one of performance turning tasks that is necessary for meowth.
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55e3572f3cd4f3e98431d4e7bcdbd5606de34935 commit 55e3572f3cd4f3e98431d4e7bcdbd5606de34935 Author: Mitsuru Oshima <oshima@chromium.org> Date: Thu Nov 01 21:22:15 2018 Reduce layers in overview mode * Change ShieldWidget's layer to NOW_DRAWN because it's always transparent. * Remove layer on image_view/title_view * Create an layer for unsnappable lable on demand. Bug: 897870 Test: no functional change. Updated the unit test. Change-Id: I23093ade07bc943ad16572d2704b78b13883c3bd Reviewed-on: https://chromium-review.googlesource.com/c/1295335 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601859}(cherry picked from commit d4804851e053bb6d1b50a0147c346b28274aec27) Reviewed-on: https://chromium-review.googlesource.com/c/1313558 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#461} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/55e3572f3cd4f3e98431d4e7bcdbd5606de34935/ash/wm/overview/overview_utils.cc [modify] https://crrev.com/55e3572f3cd4f3e98431d4e7bcdbd5606de34935/ash/wm/overview/window_grid.cc [modify] https://crrev.com/55e3572f3cd4f3e98431d4e7bcdbd5606de34935/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/55e3572f3cd4f3e98431d4e7bcdbd5606de34935/ash/wm/overview/window_selector_unittest.cc
,
Nov 1
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 55e3572f3cd4f3e98431d4e7bcdbd5606de34935 was merged to refs/branch-heads/3578 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55e3572f3cd4f3e98431d4e7bcdbd5606de34935 Commit: 55e3572f3cd4f3e98431d4e7bcdbd5606de34935 Author: oshima@chromium.org Commiter: oshima@chromium.org Date: 2018-11-01 21:22:15 +0000 UTC Reduce layers in overview mode * Change ShieldWidget's layer to NOW_DRAWN because it's always transparent. * Remove layer on image_view/title_view * Create an layer for unsnappable lable on demand. Bug: 897870 Test: no functional change. Updated the unit test. Change-Id: I23093ade07bc943ad16572d2704b78b13883c3bd Reviewed-on: https://chromium-review.googlesource.com/c/1295335 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601859}(cherry picked from commit d4804851e053bb6d1b50a0147c346b28274aec27) Reviewed-on: https://chromium-review.googlesource.com/c/1313558 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#461} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 1
oh sorry I merged wrong CL. Please let me know if you want me revert his and I'll revert.
,
Nov 2
Which did you intend to merge and which did you merge? You shouldn't have merged anything since I didn't approve a merge yet (as noted by #14!)
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0246ad98f366471175ab0728b5abaf57e09e43e commit b0246ad98f366471175ab0728b5abaf57e09e43e Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Nov 02 18:52:29 2018 Revert "Reduce layers in overview mode" This reverts commit 55e3572f3cd4f3e98431d4e7bcdbd5606de34935. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reduce layers in overview mode > > * Change ShieldWidget's layer to NOW_DRAWN because it's always transparent. > * Remove layer on image_view/title_view > * Create an layer for unsnappable lable on demand. > > Bug: 897870 > Test: no functional change. Updated the unit test. > Change-Id: I23093ade07bc943ad16572d2704b78b13883c3bd > Reviewed-on: https://chromium-review.googlesource.com/c/1295335 > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#601859}(cherry picked from commit d4804851e053bb6d1b50a0147c346b28274aec27) > Reviewed-on: https://chromium-review.googlesource.com/c/1313558 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/branch-heads/3578@{#461} > Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} TBR=oshima@chromium.org Change-Id: I8c2ab8880fc28bd0e65bcdfc376f13e8d76167ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897870 Reviewed-on: https://chromium-review.googlesource.com/c/1315697 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#475} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/b0246ad98f366471175ab0728b5abaf57e09e43e/ash/wm/overview/overview_utils.cc [modify] https://crrev.com/b0246ad98f366471175ab0728b5abaf57e09e43e/ash/wm/overview/window_grid.cc [modify] https://crrev.com/b0246ad98f366471175ab0728b5abaf57e09e43e/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/b0246ad98f366471175ab0728b5abaf57e09e43e/ash/wm/overview/window_selector_unittest.cc
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0246ad98f366471175ab0728b5abaf57e09e43e Commit: b0246ad98f366471175ab0728b5abaf57e09e43e Author: oshima@chromium.org Commiter: oshima@chromium.org Date: 2018-11-02 18:52:29 +0000 UTC Revert "Reduce layers in overview mode" This reverts commit 55e3572f3cd4f3e98431d4e7bcdbd5606de34935. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reduce layers in overview mode > > * Change ShieldWidget's layer to NOW_DRAWN because it's always transparent. > * Remove layer on image_view/title_view > * Create an layer for unsnappable lable on demand. > > Bug: 897870 > Test: no functional change. Updated the unit test. > Change-Id: I23093ade07bc943ad16572d2704b78b13883c3bd > Reviewed-on: https://chromium-review.googlesource.com/c/1295335 > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#601859}(cherry picked from commit d4804851e053bb6d1b50a0147c346b28274aec27) > Reviewed-on: https://chromium-review.googlesource.com/c/1313558 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/branch-heads/3578@{#461} > Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} TBR=oshima@chromium.org Change-Id: I8c2ab8880fc28bd0e65bcdfc376f13e8d76167ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897870 Reviewed-on: https://chromium-review.googlesource.com/c/1315697 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#475} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 2
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision b0246ad98f366471175ab0728b5abaf57e09e43e was merged to refs/branch-heads/3578 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Nov 2
Tested on canary 72.0.3598.0.0 / 11220.0.0 + nocturne/meowth. This is one of performance tuning task that we need for m71
,
Nov 5
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da2dfcdd7b5e31ce6168e4028a792d8299eb182b Commit: da2dfcdd7b5e31ce6168e4028a792d8299eb182b Author: oshima@chromium.org Commiter: oshima@chromium.org Date: 2018-11-05 20:43:09 +0000 UTC Reland "Reduce layers in overview mode" This reverts commit b0246ad98f366471175ab0728b5abaf57e09e43e. Reason for revert: merge is approved Original change's description: > Revert "Reduce layers in overview mode" > > This reverts commit 55e3572f3cd4f3e98431d4e7bcdbd5606de34935. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Reduce layers in overview mode > > > > * Change ShieldWidget's layer to NOW_DRAWN because it's always transparent. > > * Remove layer on image_view/title_view > > * Create an layer for unsnappable lable on demand. > > > > Bug: 897870 > > Test: no functional change. Updated the unit test. > > Change-Id: I23093ade07bc943ad16572d2704b78b13883c3bd > > Reviewed-on: https://chromium-review.googlesource.com/c/1295335 > > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > > Cr-Original-Commit-Position: refs/heads/master@{#601859}(cherry picked from commit d4804851e053bb6d1b50a0147c346b28274aec27) > > Reviewed-on: https://chromium-review.googlesource.com/c/1313558 > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Cr-Commit-Position: refs/branch-heads/3578@{#461} > > Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} > > TBR=oshima@chromium.org > > Change-Id: I8c2ab8880fc28bd0e65bcdfc376f13e8d76167ad > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 897870 > Reviewed-on: https://chromium-review.googlesource.com/c/1315697 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/branch-heads/3578@{#475} > Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} TBR=oshima@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 897870 Change-Id: I52c97fb6f5f79a7ebb80567899481fe29989eba2 Reviewed-on: https://chromium-review.googlesource.com/c/1318537 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#523} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da2dfcdd7b5e31ce6168e4028a792d8299eb182b commit da2dfcdd7b5e31ce6168e4028a792d8299eb182b Author: Mitsuru Oshima <oshima@chromium.org> Date: Mon Nov 05 20:43:09 2018 Reland "Reduce layers in overview mode" This reverts commit b0246ad98f366471175ab0728b5abaf57e09e43e. Reason for revert: merge is approved Original change's description: > Revert "Reduce layers in overview mode" > > This reverts commit 55e3572f3cd4f3e98431d4e7bcdbd5606de34935. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Reduce layers in overview mode > > > > * Change ShieldWidget's layer to NOW_DRAWN because it's always transparent. > > * Remove layer on image_view/title_view > > * Create an layer for unsnappable lable on demand. > > > > Bug: 897870 > > Test: no functional change. Updated the unit test. > > Change-Id: I23093ade07bc943ad16572d2704b78b13883c3bd > > Reviewed-on: https://chromium-review.googlesource.com/c/1295335 > > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > > Cr-Original-Commit-Position: refs/heads/master@{#601859}(cherry picked from commit d4804851e053bb6d1b50a0147c346b28274aec27) > > Reviewed-on: https://chromium-review.googlesource.com/c/1313558 > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Cr-Commit-Position: refs/branch-heads/3578@{#461} > > Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} > > TBR=oshima@chromium.org > > Change-Id: I8c2ab8880fc28bd0e65bcdfc376f13e8d76167ad > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 897870 > Reviewed-on: https://chromium-review.googlesource.com/c/1315697 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/branch-heads/3578@{#475} > Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} TBR=oshima@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 897870 Change-Id: I52c97fb6f5f79a7ebb80567899481fe29989eba2 Reviewed-on: https://chromium-review.googlesource.com/c/1318537 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#523} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/da2dfcdd7b5e31ce6168e4028a792d8299eb182b/ash/wm/overview/overview_utils.cc [modify] https://crrev.com/da2dfcdd7b5e31ce6168e4028a792d8299eb182b/ash/wm/overview/window_grid.cc [modify] https://crrev.com/da2dfcdd7b5e31ce6168e4028a792d8299eb182b/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/da2dfcdd7b5e31ce6168e4028a792d8299eb182b/ash/wm/overview/window_selector_unittest.cc
,
Nov 5
,
Nov 14
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by osh...@chromium.org
, Oct 22