New issue
Advanced search Search tips

Issue 897868 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Chromium references Chrome

Project Member Reported by michae...@chromium.org, Oct 22

Issue description

Some strings, include the product name in the About page with Linux apps, reference "Chrome" instead of "Chromium" when Chromium is built.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eee0be8cdfaf735971e4170621ba25a47b555e0

commit 4eee0be8cdfaf735971e4170621ba25a47b555e0
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Mon Oct 22 23:00:25 2018

Replace Chrome with Chromium in chromium_strings

See https://crrev.com/c/1294419 for a new PRESUBMIT to check this.

Bug:  897868 
Change-Id: I05fab30fdf8c0b58a8925595ff22d848b3e85176
Reviewed-on: https://chromium-review.googlesource.com/c/1294589
Reviewed-by: Zachary Kuznia <zork@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601763}
[modify] https://crrev.com/4eee0be8cdfaf735971e4170621ba25a47b555e0/chrome/app/chromium_strings.grd

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3bc867f805378d954075ece8413f8fb0e87b8b0

commit d3bc867f805378d954075ece8413f8fb0e87b8b0
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Thu Oct 25 22:48:02 2018

Presubmit check that strings use the correct product name

Motivated by strings in chromium_strings.grd that use "Chrome":
https://crrev.com/c/1294589

Bug:  897868 
Change-Id: Ie90f92e67e8801f9e78bbdf478fa727b5fee3e22
Reviewed-on: https://chromium-review.googlesource.com/c/1294419
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Zachary Kuznia <zork@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602910}
[modify] https://crrev.com/d3bc867f805378d954075ece8413f8fb0e87b8b0/PRESUBMIT.py
[modify] https://crrev.com/d3bc867f805378d954075ece8413f8fb0e87b8b0/PRESUBMIT_test.py

Status: Fixed (was: Started)

Sign in to add a comment