Chromium references Chrome |
||
Issue descriptionSome strings, include the product name in the About page with Linux apps, reference "Chrome" instead of "Chromium" when Chromium is built.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3bc867f805378d954075ece8413f8fb0e87b8b0 commit d3bc867f805378d954075ece8413f8fb0e87b8b0 Author: Michael Giuffrida <michaelpg@chromium.org> Date: Thu Oct 25 22:48:02 2018 Presubmit check that strings use the correct product name Motivated by strings in chromium_strings.grd that use "Chrome": https://crrev.com/c/1294589 Bug: 897868 Change-Id: Ie90f92e67e8801f9e78bbdf478fa727b5fee3e22 Reviewed-on: https://chromium-review.googlesource.com/c/1294419 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Zachary Kuznia <zork@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602910} [modify] https://crrev.com/d3bc867f805378d954075ece8413f8fb0e87b8b0/PRESUBMIT.py [modify] https://crrev.com/d3bc867f805378d954075ece8413f8fb0e87b8b0/PRESUBMIT_test.py
,
Oct 25
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 22