New issue
Advanced search Search tips

Issue 897864 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

spacecast package build fails at test phase

Project Member Reported by vbendeb@google.com, Oct 22

Issue description

 one of many examples can be found in 

https://luci-logdog.appspot.com/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8932004779486315840/+/steps/UnitTest/0/stdout

spacecast-0.0.1-r216: src/spacecast/common/dmserver/dmserver_test.go:92:11: unknown field 'Error' in struct literal of type "spacecast/proto/device_management_backend_proto".DeviceManagementResponse
18m 36s   spacecast-0.0.1-r216: src/spacecast/common/dmserver/dmserver_test.go:185:11: unknown field 'Error' in struct literal of type "spacecast/proto/device_management_backend_proto".DeviceManagementResponse
18m 36s   spacecast-0.0.1-r216: src/spacecast/common/dmserver/dmserver_test.go:291:11: unknown field 'Error' in struct literal of type "spacecast/proto/device_management_backend_proto".DeviceManagementResponse
18m 36s   spacecast-0.0.1-r216: src/spacecast/common/dmserver/dmserver_test.go:344:11: unknown field 'Error' in struct literal of type "spacecast/proto/device_management_backend_proto".DeviceManagementResponse
18m 36s   spacecast-0.0.1-r216: src/spacecast/common/dmserver/dmserver_test.go:397:11: unknown field 'Error' in struct literal of type "spacecast/proto/device_management_backend_proto".DeviceManagementResponse
18m 36s   spacecast-0.0.1-r216: src/spacecast/common/dmserver/dmserver_test.go:544:11: unknown field 'Error' in struct literal of type "spacecast/proto/device_management_backend_proto".DeviceManagementResponse
18m 36s   spacecast-0.0.1-r216: src/spacecast/common/dmserver/server_test.go:123:32: undefined: "spacecast/proto/device_management_backend_proto".DeviceManagementResponse_SUCCESS
18m 36s   spacecast-0.0.1-r216: src/spacecast/common/dmserver/server_test.go:124:20: undefined: "spacecast/proto/device_management_backend_proto".DeviceManagementResponse_SUCCESS
18m 36s   spacecast-0.0.1-r216: src/spacecast/common/dmserver/server_test.go:175:33: undefined: "spacecast/proto/device_management_backend_proto".DeviceManagementResponse_ErrorCode
18m 36s   spacecast-0.0.1-r216: src/spacecast/common/dmserver/server_test.go:177:8: unknown field 'Error' in struct literal of type "spacecast/proto/device_management_backend_proto".DeviceManagementResponse
18m 36s   spacecast-0.0.1-r216: src/spacecast/common/dmserver/server_test.go:177:8: too many errors
18m 36s


 
Test failures caused by proto file change introduced in https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1286551, specifically "ea5be34e Pavol Marko         Sync device management proto changes from ..".
Cc: pmarko@chromium.org
Should there be some test preventing incompatible protobuf changes?
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/platform/spacecast/+/81b5d20a6567fe40ebdfd33a52aac59f6852f20e

commit 81b5d20a6567fe40ebdfd33a52aac59f6852f20e
Author: Erdi Chen <erdi@google.com>
Date: Tue Oct 23 00:46:05 2018

Cc: -efirst@google.com
Cc: -walken@google.com -pzm@google.com
Cc: atwilson@chromium.org hendrich@chromium.org emaxx@chromium.org
+A few ChromeOS Enterprise folks for awareness

In general we try to be backwards compatible with proto changes, but as you see sometimes fields are removed when it is assumed that no one is/should be using them anymore.
I don't know the background of this particular field deprecation - it seems to come from http://cl/214999415 propagating through https://chromium-review.googlesource.com/c/chromium/src/+/1251083 into my change referenced in Comment #3.

I regularly sync the file from the master version in chromium to chromiumos (upreving the protofiles ebuild).
In most cases I manually check for removed fields and codesearch for them, but this time I didn't have the time so I decided to assume that if CQ is happy, it will be fine :-) - Sorry about the breakage!
OTOH I'm not sure I'd have identified this dependency, as I was not aware of the spacecast effort until now and that it depends on the protos.
I'm assuming these tests can't be in the CQ becuase they're in chromiumos-internal. Is there something we could do in our script to ensure that spacecast is not impacted before uploading the sync CL (i.e. which tests would we have to run / what would the command-line inside the cros_sdk be?)
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 1

Labels: merge-merged-release-R70-11021.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/platform/spacecast/+/0ec6628f0eba04c61909c77a5b29b6c42ea2460e

commit 0ec6628f0eba04c61909c77a5b29b6c42ea2460e
Author: Erdi Chen <erdi@google.com>
Date: Thu Nov 01 05:47:56 2018

Project Member

Comment 10 by sheriffbot@chromium.org, Nov 6

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, Nov 21

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-0 Pri-1
Components: -Infra>Client>ChromeOS>Test Tests
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Comment 15 by erdi@chromium.org, Jan 16 (6 days ago)

Status: Fixed (was: Assigned)

Sign in to add a comment