New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 897844 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Prefetched offline pages viewed elsewhere are not marked as such in the Downloads Home

Project Member Reported by carlosk@chromium.org, Oct 22

Issue description

Opening a Prefetched offline page from the suggested articles list in the NTP doesn't mark it as "viewed" for the Downloads Home. This effects for instance the item-viewed metrics form the latter system.

dimich@, dtrainor@: I'd like to first confirm that this is not WAI as it might (?) make sense that if the item was not opened form the DH it is not considered viewed by it.


 
To provide more context:

1) The Android.DownloadManager.InitialCount.Viewed.PrefetchedOfflinePage metric will not consider as "viewed" any prefetched articles that were opened from the NTP.

2) This would have been a problem in an initial design for the presentation of offline content on the dino page that would rely on the "viewed" information to prioritize presenting unread articles first.
Cc: harringtond@chromium.org
Hmm the open call should hit the backend when the open() call is fired.  This might depend on whether or not we properly update the lastAccessedTimeMs in the offline page backend?
The Android.DownloadManager.InitialCount.Viewed.PrefetchedOfflinePage seems to key off last_access_time > creation_time, and we seem to use offline_page_model->MarkPageAccessed(id) to leave current_time in the offline database.

I think this might not take effect immediately though, since the OfflineItems are already generated so the actual detection and reporting might happen next time the offline items collection is re-populated... Just a guess though.
Re #3: The download's open() call is not used in that case and we probably don't want to as we want to reuse the currently opened tab to open that offline page (and not a CCT as currently done when opening from the DH).

Re #4: Thanks for the potential lead!


But mind that the feedback I would like from you at this point is: Is this access-tracking disconnect between the general use of OPs and their use from the DH really an issue or WAI? Do we want non-DH views of OPs to count towards DH-based view metrics?
Re #5: I would assume the metric for Viewed reflects whether or not each item has been viewed within Chrome, but not necessarily Downloads Home (e.g. we don't necessarily detect if the user opens the file through another app directly).
Owner: carlosk@chromium.org
Status: Available (was: Untriaged)
Status: Assigned (was: Available)

Sign in to add a comment