New issue
Advanced search Search tips

Issue 897830 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
Proj-Servicification



Sign in to add a comment

Group related functions together for network::NetworkContext.

Project Member Reported by cmumford@chromium.org, Oct 22

Issue description

The HSTS funtions should be grouped together, both in network_context.mojom as well as network_context.h/cc. Review all NetworkContext functions for grouping and file ordering consistency.

For example GetHSTSRedirect a should be with the other HSTS functions (AddHSTSForTesting and IsHSTSActiveForHost).

 
Labels: Hotlist-KnownIssue
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fde6992196a95c63f3f0942f2db084426b6c87e5

commit fde6992196a95c63f3f0942f2db084426b6c87e5
Author: Chris Mumford <cmumford@google.com>
Date: Wed Nov 28 16:44:47 2018

Grouped related network::NetworkContext methods.

1. Grouped together HSTS methods.
2. Moved WriteCacheMetadata with other HttpCache methods.
3. Moved ResetURLLoaderFactories beside CreateURLLoaderFactory.
4. Grouped Proxy methods.

Bug:  897830 
Change-Id: I457539627d7245e243441f73f3a19e37fa3ddcce
Reviewed-on: https://chromium-review.googlesource.com/c/1352439
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611731}
[modify] https://crrev.com/fde6992196a95c63f3f0942f2db084426b6c87e5/services/network/network_context.cc
[modify] https://crrev.com/fde6992196a95c63f3f0942f2db084426b6c87e5/services/network/network_context.h
[modify] https://crrev.com/fde6992196a95c63f3f0942f2db084426b6c87e5/services/network/public/mojom/network_context.mojom

Status: Fixed (was: Started)

Sign in to add a comment