Count activation consumption attempts by a different same-site frame |
||||||||||||||||||
Issue descriptionUser Activation v2 allows a frame A to use the activation of another frame B only when B is a descendant of A. During the finch trial on M69 Canary/Dev, we encountered a single case ( Issue 867599 ) of a site breakage where this restriction was interacting with the popup blocker. It looks like a site problem in this particular case but there is a chance other sites behaving similarly (our finch trial was too limited to access the risk). We need to count in M71 (without UAv2) the success/failure of a LocalFrame attempting to consume the activation of another LocalFrame (i.e. same-site). This data would be helpful for Issue 728334 too, to justify the need of a new iframe attribute to allow activation visibility in subframes.
,
Oct 23
,
Oct 23
We already cut Beta RC for release this week. Pls have safe fix landed in trunk and request a merge to M71 ASAP so we can take it in for next week beta. Thank you.
,
Oct 23
Fix is out for review: https://chromium-review.googlesource.com/c/chromium/src/+/1297000
,
Oct 23
Ok, pls update the bug with canary result and request a merge so we can pick it up for next week beta if fix is safe to merge. Note: We already cut M71 beta RC for Android and Desktop for this week release on Thursday.
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1316c14aaac985a39d3beee0721d68f6063891a5 commit 1316c14aaac985a39d3beee0721d68f6063891a5 Author: Mustaq Ahmed <mustaq@google.com> Date: Wed Oct 24 11:39:22 2018 Added histograms for frames+outcomes of user activation users. Bug: 897829 Change-Id: Id1ab2eb8c4bc76c1de959e8f229a8a3298bcbc78 TBR: rkaplow@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1297000 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602299} [modify] https://crrev.com/1316c14aaac985a39d3beee0721d68f6063891a5/third_party/blink/renderer/core/frame/frame_test.cc [modify] https://crrev.com/1316c14aaac985a39d3beee0721d68f6063891a5/third_party/blink/renderer/core/frame/local_frame.cc [modify] https://crrev.com/1316c14aaac985a39d3beee0721d68f6063891a5/tools/metrics/histograms/enums.xml [modify] https://crrev.com/1316c14aaac985a39d3beee0721d68f6063891a5/tools/metrics/histograms/histograms.xml
,
Oct 24
,
Oct 24
[Auto-generated comment by a script] We noticed that this issue is targeted for M-71; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-71 label, otherwise remove Merge-TBD label. Thanks.
,
Oct 24
This will need a merge to "M71", hence adding "Merge-Request-71" label. mustag@, pls update bug with canary result tomorrow. If change looks good in canary, I will approve the merge. Thank you.
,
Oct 25
Looks like CL in C#6 has introduced a top crash on canary version 72.0.3591.0 being tracked in Issue 898772.
,
Oct 25
Thank you ajah@. Remvoing "Merge-Request-71" label and applying "Merge-TBD" label as we can't take this merge in due to stability regression listed at #10.
,
Oct 25
Reverting the change.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be3a76ad4fd374c4eb5fa3a1ed11cc00ec6331d8 commit be3a76ad4fd374c4eb5fa3a1ed11cc00ec6331d8 Author: Mustaq Ahmed <mustaq@chromium.org> Date: Thu Oct 25 15:09:32 2018 Revert "Added histograms for frames+outcomes of user activation users." This reverts commit 1316c14aaac985a39d3beee0721d68f6063891a5. Reason for revert: crbug.com/898772 Original change's description: > Added histograms for frames+outcomes of user activation users. > > Bug: 897829 > Change-Id: Id1ab2eb8c4bc76c1de959e8f229a8a3298bcbc78 > TBR: rkaplow@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/1297000 > Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602299} TBR=bokan@chromium.org,rkaplow@chromium.org,mustaq@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 897829 Change-Id: I2c2beabe36be787108f1e5fe437bd20988607fad Reviewed-on: https://chromium-review.googlesource.com/c/1299198 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#602710} [modify] https://crrev.com/be3a76ad4fd374c4eb5fa3a1ed11cc00ec6331d8/third_party/blink/renderer/core/frame/frame_test.cc [modify] https://crrev.com/be3a76ad4fd374c4eb5fa3a1ed11cc00ec6331d8/third_party/blink/renderer/core/frame/local_frame.cc [modify] https://crrev.com/be3a76ad4fd374c4eb5fa3a1ed11cc00ec6331d8/tools/metrics/histograms/enums.xml [modify] https://crrev.com/be3a76ad4fd374c4eb5fa3a1ed11cc00ec6331d8/tools/metrics/histograms/histograms.xml
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46dc0b4901ec878b92d74b30f22daafa49a60c0d commit 46dc0b4901ec878b92d74b30f22daafa49a60c0d Author: Mustaq Ahmed <mustaq@chromium.org> Date: Thu Oct 25 15:16:12 2018 Revert "Added histograms for frames+outcomes of user activation users." This reverts commit 1316c14aaac985a39d3beee0721d68f6063891a5. Reason for revert: crbug.com/898772 Original change's description: > Added histograms for frames+outcomes of user activation users. > > Bug: 897829 > Change-Id: Id1ab2eb8c4bc76c1de959e8f229a8a3298bcbc78 > TBR: rkaplow@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/1297000 > Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602299} TBR=bokan@chromium.org,rkaplow@chromium.org,mustaq@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 897829 Change-Id: I2c2beabe36be787108f1e5fe437bd20988607fad Reviewed-on: https://chromium-review.googlesource.com/c/1299198 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602710}(cherry picked from commit be3a76ad4fd374c4eb5fa3a1ed11cc00ec6331d8) Reviewed-on: https://chromium-review.googlesource.com/c/1299335 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/3591@{#3} Cr-Branched-From: 9ea5237fddb8c0031d3517ec49c3ae94912bacad-refs/heads/master@{#602531} [modify] https://crrev.com/46dc0b4901ec878b92d74b30f22daafa49a60c0d/third_party/blink/renderer/core/frame/frame_test.cc [modify] https://crrev.com/46dc0b4901ec878b92d74b30f22daafa49a60c0d/third_party/blink/renderer/core/frame/local_frame.cc [modify] https://crrev.com/46dc0b4901ec878b92d74b30f22daafa49a60c0d/tools/metrics/histograms/enums.xml [modify] https://crrev.com/46dc0b4901ec878b92d74b30f22daafa49a60c0d/tools/metrics/histograms/histograms.xml
,
Oct 29
We're cutting M71 Beta RC tomorow @ 1:00 PM PT for release on Wednesday, pls request a merge to M71 once safe fix is ready to merge. Thank you.
,
Oct 30
Per chat with mustaq@, we will take this merge in for next week beta as change is not landed in trunk yet.
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1011f64b2bab81798342a15508cb7c053e252ded commit 1011f64b2bab81798342a15508cb7c053e252ded Author: Mustaq Ahmed <mustaq@google.com> Date: Wed Oct 31 17:55:13 2018 Added histograms for frames+outcomes of user activation consumers. Bug: 897829 Change-Id: I652665d6a0531ac820329cb64ce073c3b517c8b6 TBR: rkaplow@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1299537 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#604324} [modify] https://crrev.com/1011f64b2bab81798342a15508cb7c053e252ded/third_party/blink/renderer/core/frame/frame_test.cc [modify] https://crrev.com/1011f64b2bab81798342a15508cb7c053e252ded/third_party/blink/renderer/core/frame/local_frame.cc [modify] https://crrev.com/1011f64b2bab81798342a15508cb7c053e252ded/tools/metrics/histograms/enums.xml [modify] https://crrev.com/1011f64b2bab81798342a15508cb7c053e252ded/tools/metrics/histograms/histograms.xml
,
Oct 31
Pls update bug with canary result tomorrow. Thank you.
,
Oct 31
,
Nov 1
The NextAction date has arrived: 2018-11-01
,
Nov 1
Verified the added counters through chrome://histograms/UserActivation in Windows Canary 72.0.3598.0, working as expected.
,
Nov 1
,
Nov 1
Correcting the request label, oops.
,
Nov 1
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 1
Approving merge to M71 branch 3578 based on comment #21.
,
Nov 1
Pls merge your change to M71 branch 3578 ASAP so we can pick it up for next beta release. Thank you.
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef2b1fd64c3a43fcfd43c2c5947e0fa96afc128f commit ef2b1fd64c3a43fcfd43c2c5947e0fa96afc128f Author: Mustaq Ahmed <mustaq@google.com> Date: Fri Nov 02 13:47:37 2018 Added histograms for frames+outcomes of user activation consumers. Bug: 897829 Change-Id: I652665d6a0531ac820329cb64ce073c3b517c8b6 TBR: rkaplow@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1299537 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604324}(cherry picked from commit 1011f64b2bab81798342a15508cb7c053e252ded) Reviewed-on: https://chromium-review.googlesource.com/c/1314610 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#471} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/ef2b1fd64c3a43fcfd43c2c5947e0fa96afc128f/third_party/blink/renderer/core/frame/frame_test.cc [modify] https://crrev.com/ef2b1fd64c3a43fcfd43c2c5947e0fa96afc128f/third_party/blink/renderer/core/frame/local_frame.cc [modify] https://crrev.com/ef2b1fd64c3a43fcfd43c2c5947e0fa96afc128f/tools/metrics/histograms/enums.xml [modify] https://crrev.com/ef2b1fd64c3a43fcfd43c2c5947e0fa96afc128f/tools/metrics/histograms/histograms.xml
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef2b1fd64c3a43fcfd43c2c5947e0fa96afc128f Commit: ef2b1fd64c3a43fcfd43c2c5947e0fa96afc128f Author: mustaq@google.com Commiter: mustaq@chromium.org Date: 2018-11-02 13:47:37 +0000 UTC Added histograms for frames+outcomes of user activation consumers. Bug: 897829 Change-Id: I652665d6a0531ac820329cb64ce073c3b517c8b6 TBR: rkaplow@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1299537 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604324}(cherry picked from commit 1011f64b2bab81798342a15508cb7c053e252ded) Reviewed-on: https://chromium-review.googlesource.com/c/1314610 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#471} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by gov...@chromium.org
, Oct 23