New issue
Advanced search Search tips

Issue 897823 link

Starred by 1 user
Status: Fixed
Owner:
afakhry@chromium.org
Closed: Dec 10
Cc:
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Make sure top-controls-slide works with single process mash

Project Member Reported by sky@chromium.org, Oct 22 
There are a handful of browser_tests that are disabled in single-process-mash for this. The tests are marked disabled against something that should now work. These tests need to be reevaluated as well as making sure the feature generally works.

Comment 1 by afakhry@chromium.org, Oct 22 

I think those tests are now working in SingleProcessMash. We can probably re-enable them all and watch for any flakes.

Comment 3 by afakhry@chromium.org, Oct 22 

-TopControlsSlideControllerTest.DisplayRotation
-TopControlsSlideControllerTest.TestClosingATab
-TopControlsSlideControllerTest.TestFocusEditableElements
-TopControlsSlideControllerTest.TestScrollingMaximizedPageBeforeGoingToTabletMode
-TopControlsSlideControllerTest.TestScrollingPage
-TopControlsSlideControllerTest.TestScrollingPageAndSwitchingToNTP

Comment 4 by est...@chromium.org, Oct 22 

Yea, they seem to all work in single process mash but at least one hangs in multi process mash.

Comment 5 by afakhry@chromium.org, Oct 22 

Which one?

Comment 6 by est...@chromium.org, Oct 22 

7 tests timed out:
    TopControlsSlideControllerTest.DisplayRotation (../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:723)
    TopControlsSlideControllerTest.TestClosingATab (../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:550)
    TopControlsSlideControllerTest.TestDropDowns (../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:843)
    TopControlsSlideControllerTest.TestFocusEditableElements (../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:607)
    TopControlsSlideControllerTest.TestIntermediateSliding (../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:939)
    TopControlsSlideControllerTest.TestScrollingMaximizedPageBeforeGoingToTabletMode (../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:891)
    TopControlsSlideControllerTest.TestScrollingPage (../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:447)

Comment 7 by afakhry@chromium.org, Oct 22 

You can assign to me and I can take a look.

Comment 8 by est...@chromium.org, Oct 22

Cc: -afakhry@chromium.org est...@chromium.org
Owner: afakhry@chromium.org

Comment 9 by sky@chromium.org, Nov 5

Labels: Pri-2

Comment 10 by sky@chromium.org, Dec 10

Status: Fixed (was: Assigned)
These tests are no longer excluded. I have no doubt there is work to be done for multi-process mash, but single-process mash appears good. I'm closing out.
►

Sign in to add a comment