Implement generic wrapper scripts for third_party/blink/tools/run_web_tests.py |
|||||
Issue descriptionMy plan to tackle this: 1) Generate the wrapper script for run_web_tests.py in out/<...> that have all arguments that are constant at build time defined. 2) Convert the src json to use the wrapper script in (1) 3) Let blink-dev@ now the way to run layout tests is to use the script in out/...<..> 4) Remove support for --target & --configuration. At this point, python script can always assume the location of the out/ & can parse the configuration from args.gn file.
,
Oct 22
,
Oct 22
Sounds like a good plan :).
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94d77dfeda67dff62c8ea51cecc2cbe6b82263d9 commit 94d77dfeda67dff62c8ea51cecc2cbe6b82263d9 Author: Ned Nguyen <nednguyen@google.com> Date: Tue Nov 06 00:38:07 2018 Add generator_script and modify BUILD to generate a wrapper script that runs layout tests with build target prefilled Bug: 897803 Change-Id: I21c00b8924e38304903cf10840fdf5bea1ebb864 Reviewed-on: https://chromium-review.googlesource.com/c/1296990 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#605539} [modify] https://crrev.com/94d77dfeda67dff62c8ea51cecc2cbe6b82263d9/BUILD.gn [add] https://crrev.com/94d77dfeda67dff62c8ea51cecc2cbe6b82263d9/testing/scripts/generators/gen_run_web_tests_script.py [modify] https://crrev.com/94d77dfeda67dff62c8ea51cecc2cbe6b82263d9/testing/test.gni
,
Nov 6
,
Jan 10
Reassign to Erik to triage
,
Jan 10
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nedngu...@google.com
, Oct 22