New issue
Advanced search Search tips

Issue 897801 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

PDFExtensionClipboardTest.IndividualShiftLeftArrowPresses is flaky

Project Member Reported by sky@chromium.org, Oct 22

Issue description

It fairly consistently times out. Sometimes it'll pass on the retry, but not always. The flakiness dashboard shows this happening everywhere (windows, linux...) Judging by the name, if the test is relying on the clipboard it should be in interactive_ui_tests as it's possible some other test (that should also be in interactive_ui_tests) is using the clipboard.

[ RUN      ] PDFExtensionClipboardTest.IndividualShiftLeftArrowPresses
[13523:13523:1022/044826.004765:WARNING:chrome_browser_main_chromeos.cc(547)] Running as stub user with profile dir: test-user
[13523:13523:1022/044826.101914:ERROR:external_web_apps.cc(176)] Determining directory
[13523:13523:1022/044826.103207:ERROR:external_web_apps.cc(207)] Scanning /usr/share/chromium/extensions/web_apps
[13523:13523:1022/044826.105205:INFO:easy_unlock_service_regular.cc(163)] DeviceSyncClient is not ready yet, delaying UseLoadedRemoteDevices().
[13523:13523:1022/044826.124749:INFO:remote_commands_service.cc(38)] Fetching remote commands.
[13523:13523:1022/044826.161139:WARNING:remote_commands_service.cc(40)] Client is not registered.
[13523:13523:1022/044826.161193:INFO:remote_commands_invalidator.cc(32)] Initialize RemoteCommandsInvalidator.
[13523:13523:1022/044826.161226:INFO:remote_commands_invalidator.cc(57)] Starting RemoteCommandsInvalidator.
[13523:13523:1022/044826.161254:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData.
[13523:13523:1022/044826.161301:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator.
[13523:13523:1022/044826.177849:ERROR:external_web_apps.cc(176)] Determining directory
[13523:13523:1022/044826.177877:ERROR:external_web_apps.cc(207)] Scanning 
[13523:13523:1022/044826.200812:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
[13523:13523:1022/044826.270962:INFO:secure_channel_service.cc(25)] SecureChannelService::OnStart()
[13523:13523:1022/044826.270985:INFO:secure_channel_initializer.cc(64)] SecureChannelInitializer::SecureChannelInitializer(): Fetching Bluetooth adapter. All requests received before the adapter is fetched will be queued.
[13523:13523:1022/044826.271010:INFO:secure_channel_service.cc(38)] SecureChannelService::OnBindInterface() for interface chromeos.secure_channel.mojom.SecureChannel.
[13523:13523:1022/044826.271067:INFO:device_sync_service.cc(30)] DeviceSyncService::OnStart()
[13523:13523:1022/044826.281710:INFO:device_sync_service.cc(46)] DeviceSyncService::OnBindInterface() from interface chromeos.device_sync.mojom.DeviceSync.
[13523:13523:1022/044826.281847:INFO:multidevice_setup_service.cc(62)] MultiDeviceSetupService::OnStart()
[13523:13523:1022/044826.287448:INFO:multidevice_setup_service.cc(75)] MultiDeviceSetupService::OnBindInterface() from interface chromeos.multidevice_setup.mojom.MultiDeviceSetup.
[13523:13523:1022/044826.313460:INFO:secure_channel_initializer.cc(119)] SecureChannelInitializer::OnBluetoothAdapterReceived(): Bluetooth adapter has been fetched. Passing all queued requests to the service.
[13523:13523:1022/044826.319272:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *)
[13523:13523:1022/044826.334187:INFO:multidevice_setup_service.cc(75)] MultiDeviceSetupService::OnBindInterface() from interface chromeos.multidevice_setup.mojom.MultiDeviceSetup.
[13523:13768:1022/044826.409715:WARNING:embedded_test_server.cc(239)] Request not handled. Returning 404: /favicon.ico
[13523:13523:1022/044826.518924:INFO:CONSOLE(0)] "HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.", source:  (0)
[13523:13523:1022/044826.609727:INFO:CONSOLE(442)] "document.registerElement is deprecated and will be removed in M73, around March 2019. Please use window.customElements.define instead. See https://www.chromestatus.com/features/4642138092470272 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-micro-extracted.js (442)
[13523:13523:1022/044826.705244:INFO:CONSOLE(2083)] "Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-mini-extracted.js (2083)
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x00000426510f base::debug::StackTrace::StackTrace()
#1 0x000004752db5 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f0bd20f1cb0 <unknown>
#3 0x7f0bd21b33c9 syscall
#4 0x0000041f21de base::internal::MessageLoopTaskRunner::RunsTasksInCurrentSequence()
#5 0x00000421032c base::(anonymous namespace)::ProxyToTaskRunner()
#6 0x000001da6469 _ZN4base8internal13FunctorTraitsIPFv13scoped_refptrINS_10TaskRunnerEENS_12OnceCallbackIFvvEEEEvE6InvokeIRKS9_JRKS2_INS_22SingleThreadTaskRunnerEERKNS_17RepeatingCallbackIS6_EEEEEvOT_DpOT0_
#7 0x00000427a621 base::debug::TaskAnnotator::RunTask()
#8 0x0000041f0d4f base::MessageLoop::RunTask()
#9 0x0000041f10a3 base::MessageLoop::DoWork()
#10 0x000004276d39 base::MessagePumpLibevent::Run()
#11 0x00000420f9e5 base::RunLoop::Run()
#12 0x000004775115 content::RunAllPendingInMessageLoop()
#13 0x000000b36695 PDFExtensionClipboardTest::CheckClipboard()
#14 0x000000b2cfe6 PDFExtensionClipboardTest_IndividualShiftLeftArrowPresses_Test::RunTestOnMainThread()
#15 0x00000475227b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#16 0x00000431dc34 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#17 0x00000431cb7c ChromeBrowserMainParts::PreMainMessageLoopRun()
#18 0x000001d6a329 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#19 0x000002d33d6a content::BrowserMainLoop::PreMainMessageLoopRun()
#20 0x0000030c1a17 content::StartupTaskRunner::RunAllTasksNow()
#21 0x000002d329a6 content::BrowserMainLoop::CreateStartupTasks()
#22 0x000002d360a0 content::BrowserMainRunnerImpl::Initialize()
#23 0x000002d30a04 content::BrowserMain()
#24 0x000003f7f934 content::ContentMainRunnerImpl::Run()
#25 0x000005f409f0 service_manager::Main()
#26 0x000003f7ddf4 content::ContentMain()
#27 0x000004751ea3 content::BrowserTestBase::SetUp()
#28 0x0000042cb7ae InProcessBrowserTest::SetUp()
#29 0x0000021aa3cd testing::Test::Run()
#30 0x0000021aaff0 testing::TestInfo::Run()
#31 0x0000021ab507 testing::TestCase::Run()
#32 0x0000021b72d7 testing::internal::UnitTestImpl::RunAllTests()
#33 0x0000021b6e4d testing::UnitTest::Run()
#34 0x0000042e1c31 base::TestSuite::Run()
#35 0x0000041d246d ChromeTestSuiteRunner::RunTestSuite()
#36 0x000004771dde content::LaunchTests()
#37 0x0000041d2925 LaunchChromeTests()
#38 0x0000041d23fe main
#39 0x7f0bd20dcf45 __libc_start_main
#40 0x00000072652a _start
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51267d5642dcdabd9424c8c3011b0104a4fd4243

commit 51267d5642dcdabd9424c8c3011b0104a4fd4243
Author: Scott Violet <sky@chromium.org>
Date: Mon Oct 22 18:05:43 2018

disables PDFExtensionClipboardTest.IndividualShiftLeftArrowPresses

It's flaky.

BUG=897801
TEST=test only change
TBR=thestig@chromium.org

Change-Id: Ieba62e4047a3fc240ac6b09b6e526ff87a0e29d3
Reviewed-on: https://chromium-review.googlesource.com/c/1294197
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601649}
[modify] https://crrev.com/51267d5642dcdabd9424c8c3011b0104a4fd4243/chrome/browser/pdf/pdf_extension_test.cc

Cc: -thestig@chromium.org
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
The test uses ui::TestClipboard so there should be no interference with the real system clipboard. There are 4 PDFExtensionClipboardTest test cases, so if this one is flaky due to clipboard issues, then the others should be flaky as well. I'll double check to see if that is the case and see if I can reproduce this issue locally.
Here's the flakiness dashboard query I used: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=PDFExtensionClipboardTest.IndividualShiftLeftArrowPresses . The test often passes on the retry, but not always.
PDFExtensionClipboardTest.CombinedShiftArrowPresses is also flaky.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec52747a5abc25a862843edca761104b3c319764

commit ec52747a5abc25a862843edca761104b3c319764
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Jan 14 16:16:49 2019

[ui_controls] Unflake Send*NotifyWhenDone() on Windows

ui_controls::Send*NotifyWhenDone() can be flaky when invoked after
ui_controls::Send*() as the former can decide to notify based on
observing a yet-to-be-processed event from the latter (or even a
yet-to-be-processed event emitted by unrelated code) and thus notify too
early, resuming and testing conditions that have yet to be met.

Solution: defer the notification if the system queue has pending events
of the same type awaiting dispatch.

Note: mouse move can be repeated indefinitely during a drag, as such we
consider a mouse move complete when it hits the target regardless of
remaining mouse move messages in the queue.

@ BUG OWNERS : This might unflake many currently disabled tests. I've
CC'ed interactive_ui_tests + Windows bugs, please try to re-enable your
test after this CL if you think it might be related.

Bug:  892228 , 640996, 897801,893078,876224,875443,873110,852786,850343,848049,846695,840369,798492,756338,751031,665296,651906,499858,468660,419468,238347,131612,106489,97777,92467
Change-Id: I548856a3948ff71a145435799b4ba3e689561f14
Reviewed-on: https://chromium-review.googlesource.com/c/1392178
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622470}
[modify] https://crrev.com/ec52747a5abc25a862843edca761104b3c319764/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
[modify] https://crrev.com/ec52747a5abc25a862843edca761104b3c319764/ui/base/test/ui_controls_internal_win.cc

Sign in to add a comment