Refactor ChromeVirtualKeyboardDelegate to use ChromeKeyboardControllerClient |
||
Issue descriptionFor out-of-process-ash, ChromeVirtualKeyboardDelegate will no longer be able to interact with keyboard::KeybaordController directly since it lives in Ash. ChromeKeyboardControllerClient provides an interface for calling into ash::KeyboardController and needs to be used instead. Some code has already been migrated to use this interface, however ChromeVirtualKeyboardDelegate is more complicated and will need to be re-factored as a separate effort.
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/943aa97737ee18f922015e1b9d826f39d44e9978 commit 943aa97737ee18f922015e1b9d826f39d44e9978 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Oct 23 17:52:31 2018 Move KeyboardController::InsertText to ChromeVirtualKeyboardDelegate Currently KeyboardController::InsertText is only accessed by ChromeVirtualKeyboardDelegate. Since this is the only public KeyboardController method that accesses KeyboardUI::GetInputMethod, it makes sense to move this out of KeyboardController to simplify the future conversion of KeyboardController's access to ui::InputMethod. Bug: 897793 Change-Id: Ifd63e3666177728ad77b62b1532e2d252eb8d6b9 Reviewed-on: https://chromium-review.googlesource.com/c/1294109 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#602014} [modify] https://crrev.com/943aa97737ee18f922015e1b9d826f39d44e9978/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc [modify] https://crrev.com/943aa97737ee18f922015e1b9d826f39d44e9978/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/943aa97737ee18f922015e1b9d826f39d44e9978/ui/keyboard/keyboard_controller.h
,
Nov 15
***UI Mass Triage*** Since work is in progress, adding appropriate labels. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 23