New issue
Advanced search Search tips

Issue 897775 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 29
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

external/wpt/performance-timeline/webtiming-resolution.any.html and 1 other(s) in webkit_layout_tests failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Oct 22

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of yigu@chromium.org

external/wpt/performance-timeline/webtiming-resolution.any.html and 1 other(s) in webkit_layout_tests failing on multiple builders

Builders failed on: 
- Mac10.12 Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests
- Mac10.13 Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests
- WebKit Win10: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Win10
- Win7 Tests (1): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29


 
Cc: -yigu@chromium.org
Labels: -Sheriff-Chromium
Owner: npm@chromium.org
Status: Assigned (was: Available)
Hi npm@, PTAL and further triage the issue if necessary. Thanks!
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bcf7b9a9d356a967dd94f2eddb3c74093f2d937

commit 9bcf7b9a9d356a967dd94f2eddb3c74093f2d937
Author: Yi Gu <yigu@chromium.org>
Date: Mon Oct 22 16:37:12 2018

Add failure tests to expectations

The following tests keep failing on Win and Mac. Add them to
TestExpectation and add test owner for review.

TBR=npm@chromium.org
NOTRY=true

Bug:  897775 
Change-Id: I14898c603e5a280c747b8d016589c3760a172ee4
Reviewed-on: https://chromium-review.googlesource.com/c/1293995
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601610}
[modify] https://crrev.com/9bcf7b9a9d356a967dd94f2eddb3c74093f2d937/third_party/WebKit/LayoutTests/TestExpectations

Cc: npm@chromium.org
Owner: skyos...@chromium.org
Reassign the bug to skyostil@ as the following patch is likely related to the issue.
https://chromium-review.googlesource.com/c/chromium/src/+/1290916
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a29d51e06d211eea69ae25d1578f99b3e101417

commit 1a29d51e06d211eea69ae25d1578f99b3e101417
Author: Yi Gu <yigu@chromium.org>
Date: Mon Oct 22 16:59:18 2018

Update test failures in TestExpectation

Suspecting patch crrev.com/c/1290916 causes test failures. As the patch
was landed several hours ago, I'd like to disable the tests and assign
the owner for review.

TBR=skyostil@chromium.org
NOTRY=true

Bug:  897775 
Change-Id: I416121366cae0d4503b1b02db075722be43db6a9
Reviewed-on: https://chromium-review.googlesource.com/c/1294129
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601617}
[modify] https://crrev.com/1a29d51e06d211eea69ae25d1578f99b3e101417/third_party/WebKit/LayoutTests/TestExpectations

Status: Started (was: Assigned)
Fix here: https://chromium-review.googlesource.com/c/chromium/src/+/1298017
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1231234048129f8755fe2081341a7f6f71c0ef86

commit 1231234048129f8755fe2081341a7f6f71c0ef86
Author: Sami Kyostila <skyostil@chromium.org>
Date: Mon Oct 29 11:57:23 2018

WPT: Adjust expected timing resolution

We recently increased[1] the minimum resolution of web-exposed timers.
This patch relaxes the WPT tests accordingly to allow for a higher
resolution (with a small delta to account for floating point errors).

Bug:  897775 

[1] https://chromium-review.googlesource.com/c/1290916

Change-Id: I6f8a8d8ac2b827ae54718db6f8940cafb1cad665
Reviewed-on: https://chromium-review.googlesource.com/c/1298017
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603461}
[modify] https://crrev.com/1231234048129f8755fe2081341a7f6f71c0ef86/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/1231234048129f8755fe2081341a7f6f71c0ef86/third_party/WebKit/LayoutTests/external/wpt/performance-timeline/webtiming-resolution.any.js

Status: Fixed (was: Started)

Sign in to add a comment