Chrome OS shelf placement broken in unified display mode |
|||||
Issue description
Chrome OS shelf placement broken in unified display mode
On Chrome OS 72.0.3582.0 and ToT linux-chromeos @ #600836
(1) Enable unified mode in about:flags #ash-enable-unified-desktop and plug in another display.
(or run chrome --ash-enable-unified-desktop --ash-host-window-bounds=500x500,0+500-500x500)
(2) Set the shelf to the right position (right click desktop -> Shelf position -> right)
Expected: Shelf is on the right side of the unified desktop (right display), doesn't spill between displays.
Actual: Shelf is in the middle of the unified desktop (right side of left display), spills onto right display.
See the attached image for the right side shelf in unified mode on linux-chromeos.
,
Oct 26
,
Oct 30
I think we also need to define the launcher behavior in Unified Mode (cc: ovanieva@, newcomer@, and omrilio@) (See attached video). This is a 4x4 display matrix in unified mode. See where the shelf is positioned and how big it is. Now see where the launcher starts showing? After some discussion with oshima@, we can do the following in unified mode: - Bottom shelf alignment, position shelf in the bottom left display of the matrix. - Left alignment, position shelf in the top left display of the matrix. - Right alignment, position shelf in the top right display of the matrix.
,
Oct 30
Should the launcher only take up one full screen? Since the analogy with the launcher/shelf is that the launcher grows from the shelf (launcher/shelf should be considered the same surface), should we limit the size of the launcher in this case?
,
Oct 30
This would seem like the desired behavior yes I wasn't aware of this mode so this is my gut reaction.
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ac713b7c88f9a4ffb2f54db3724ec7453280551 commit 1ac713b7c88f9a4ffb2f54db3724ec7453280551 Author: Ahmed Fakhry <afakhry@chromium.org> Date: Tue Nov 06 18:57:46 2018 Fix shelf positioning in Unified Desktop mode This CL changes the default behavior from always placing the shelf on the top-left display in the unified matrix, to placing it according to its aligment: - "left" alignment -> top-left display in the matrix. - "right" alignment -> top-right display in the matrix. - "bottom" alignment -> bottom-left display in the matrix. This CL also fixes the shelf positioning when changing the unified display zoom (the unified scale factor was not taken into consideration). BUG= 897771 TEST=Modified tests. Change-Id: Idf7a364ce40340e69a1dbb8785318725ea1aa890 Reviewed-on: https://chromium-review.googlesource.com/c/1315711 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#605765} [modify] https://crrev.com/1ac713b7c88f9a4ffb2f54db3724ec7453280551/ash/display/cros_display_config.cc [modify] https://crrev.com/1ac713b7c88f9a4ffb2f54db3724ec7453280551/ash/display/display_configuration_controller.cc [modify] https://crrev.com/1ac713b7c88f9a4ffb2f54db3724ec7453280551/ash/display/display_configuration_controller.h [modify] https://crrev.com/1ac713b7c88f9a4ffb2f54db3724ec7453280551/ash/display/display_manager_unittest.cc [modify] https://crrev.com/1ac713b7c88f9a4ffb2f54db3724ec7453280551/ash/screen_util.cc [modify] https://crrev.com/1ac713b7c88f9a4ffb2f54db3724ec7453280551/ash/screen_util_unittest.cc [modify] https://crrev.com/1ac713b7c88f9a4ffb2f54db3724ec7453280551/chrome/browser/extensions/system_display/display_info_provider_chromeos_unittest.cc [modify] https://crrev.com/1ac713b7c88f9a4ffb2f54db3724ec7453280551/ui/display/manager/display_manager.cc [modify] https://crrev.com/1ac713b7c88f9a4ffb2f54db3724ec7453280551/ui/display/manager/display_manager.h [modify] https://crrev.com/1ac713b7c88f9a4ffb2f54db3724ec7453280551/ui/display/unified_desktop_utils.h
,
Nov 6
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by osh...@chromium.org
, Oct 22