New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 897765 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Enable WebAuthN M70 Features By Default in M71

Project Member Reported by jdoerrie@chromium.org, Oct 22

Issue description

WebAuthN caBLE, Transport Selection UX and Touch ID Support launched in M70 [1,2]. In M70 these features are launched via Finch, and we would like to enable them by default for M71. r600862 enabled them by default for M72, but we should merge it back, so that the changes are active in M71 as well.

[1] https://crbug.com/873195
[2] https://crbug.com/837392
 
Labels: Merge-Request-71 M-71
Requesting merge of r600862 into M71 (branch 3578).
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 23

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls merge you change to M71 ASAP so we can pick it up for next week beta release. Thank you.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 23

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04ff088d5681e91192ef330ff9b109b3dbb9c235

commit 04ff088d5681e91192ef330ff9b109b3dbb9c235
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Oct 23 17:18:41 2018

[WebAuthN] Enable M70 Features By Default

This change enables the WebAuthN M70 Features "WebAuthenticationUI",
"WebAuthenticationTouchId" and "WebAuthenticationCableWin" by default.

Relevant Launch Bugs:
- TouchId: https://crbug.com/837392
- UI and CableWin: https://crbug.com/873195

TBR=jochen@chromium.org

Bug:  897765 
Change-Id: I3693fbd28c0b11978a045c7fa9f68c9e4995c1a0
Reviewed-on: https://chromium-review.googlesource.com/c/1288795
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600862}(cherry picked from commit 6bc8e4216954d736db67110a247bac5846c2c68e)
Reviewed-on: https://chromium-review.googlesource.com/c/1296672
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#267}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/04ff088d5681e91192ef330ff9b109b3dbb9c235/chrome/common/chrome_features.cc
[modify] https://crrev.com/04ff088d5681e91192ef330ff9b109b3dbb9c235/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/04ff088d5681e91192ef330ff9b109b3dbb9c235/content/public/common/content_features.cc
[modify] https://crrev.com/04ff088d5681e91192ef330ff9b109b3dbb9c235/device/base/features.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/04ff088d5681e91192ef330ff9b109b3dbb9c235

Commit: 04ff088d5681e91192ef330ff9b109b3dbb9c235
Author: jdoerrie@chromium.org
Commiter: jdoerrie@chromium.org
Date: 2018-10-23 17:18:41 +0000 UTC

[WebAuthN] Enable M70 Features By Default

This change enables the WebAuthN M70 Features "WebAuthenticationUI",
"WebAuthenticationTouchId" and "WebAuthenticationCableWin" by default.

Relevant Launch Bugs:
- TouchId: https://crbug.com/837392
- UI and CableWin: https://crbug.com/873195

TBR=jochen@chromium.org

Bug:  897765 
Change-Id: I3693fbd28c0b11978a045c7fa9f68c9e4995c1a0
Reviewed-on: https://chromium-review.googlesource.com/c/1288795
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600862}(cherry picked from commit 6bc8e4216954d736db67110a247bac5846c2c68e)
Reviewed-on: https://chromium-review.googlesource.com/c/1296672
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#267}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Status: Fixed (was: Started)

Sign in to add a comment