New issue
Advanced search Search tips

Issue 897764 link

Starred by 1 user
Status: Fixed
Owner:
wanderview@chromium.org
Closed: Nov 27
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

content_browsertests ServiceWorkerNavigationPreloadTest.GetLargeResponseReadableStream failing on chromium.win/Win7 Tests (dbg)(1)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Oct 22 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of yigu@chromium.org

content_browsertests failing on chromium.win/Win7 Tests (dbg)(1)

Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29

Comment 1 by yigu@chromium.org, Oct 22

Cc: -yigu@chromium.org
Owner: tkent@chromium.org
Status: Assigned (was: Available)
Suspecting the following patch caused the failures. Disabling the tests as the patch was landed more than 1 hour ago.
tkent@, PTAL. Thanks!

Log:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8931972527691491104/+/steps/content_browsertests/0/logs/ServiceWorkerNavigationPreloadTest.GetLargeResponseReadableStream/0
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5611c4fab0cabf1f8ecdeaba58c0e93c196e4ea

commit e5611c4fab0cabf1f8ecdeaba58c0e93c196e4ea
Author: Yi Gu <yigu@chromium.org>
Date: Mon Oct 22 16:05:20 2018

Disable GetLargeResponseReadableStream on Win

TBR=tkent@chromium.org
NOTRY=true

Bug:  897764 
Change-Id: I3a2dee4561c5f7f22436dcc002a5ba6d57a5502c
Reviewed-on: https://chromium-review.googlesource.com/c/1293989
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601598}
[modify] https://crrev.com/e5611c4fab0cabf1f8ecdeaba58c0e93c196e4ea/content/browser/service_worker/service_worker_browsertest.cc

Comment 4 by yigu@chromium.org, Oct 22

Labels: -Sheriff-Chromium

Comment 5 by tkent@google.com, Oct 22

Components: Blink>ServiceWorker
Owner: wanderview@chromium.org
Summary: content_browsertests ServiceWorkerNavigationPreloadTest.GetLargeResponseReadableStream failing on chromium.win/Win7 Tests (dbg)(1) (was: content_browsertests failing on chromium.win/Win7 Tests (dbg)(1))
My CL must be unrelated to the test.
Assign to the test author.

Comment 6 by mek@chromium.org, Oct 23 

This is in fact a bug in the test. It combines chunks it receives using Array.prototype.join, which by default comma separates the chunks. Instead it should be passing the empty string to join() to make sure no random commas end up in the output.

Comment 7 by wanderview@chromium.org, Oct 23 

Thanks Marijn for identifying the problem.  I'll make a CL.  Might be a bit delayed due to TPAC.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/761d47b92a18dfe12a2a81d1c4e2470fce383c63

commit 761d47b92a18dfe12a2a81d1c4e2470fce383c63
Author: Ben Kelly <wanderview@chromium.org>
Date: Tue Oct 23 09:32:11 2018

Fix ServiceWorkerNavigationPreloadTest.GetLargeResponseReadableStream to join chunks correctly.

R=mek@chromium.org

Bug:  897764 
Change-Id: I256e6d3a051f56fff9f07a4b09b490086a6474d5
Reviewed-on: https://chromium-review.googlesource.com/c/1296190
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601888}
[modify] https://crrev.com/761d47b92a18dfe12a2a81d1c4e2470fce383c63/content/browser/service_worker/service_worker_browsertest.cc

Comment 9 by falken@chromium.org, Nov 27

Status: Fixed (was: Assigned)
This looks fixed. Great!
►

Sign in to add a comment