Refactor common code from cros_config_schema and cros_config_test_schema |
||
Issue descriptionRefactor common code and tests from cros_config_schema and cros_config_test_schema. There are a lot of common functions and tests and a few functions that need a bit of rework.
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/89a6cafe165c2c49e8c7b5f11ca4e747066ae703 commit 89a6cafe165c2c49e8c7b5f11ca4e747066ae703 Author: Gregory Meinke <gmeinke@chromium.org> Date: Fri Nov 09 22:43:53 2018 chromeos-config: Fix test schema json format BUG= chromium:891857 , chromium:897753 TEST=local unittests and output format read in tast test Output json was not pretty printed correctly causing file to be a string with newline chars instead of actual newlines. This broke the Golang unmarshal to struct. Refactored a bunch of cros_config_schema to use the common schema functions. Change-Id: I0cf2650050513d8a74693404af24bd55b7aac4f1 Reviewed-on: https://chromium-review.googlesource.com/1312647 Commit-Ready: Gregory Meinke <gmeinke@chromium.org> Tested-by: Gregory Meinke <gmeinke@chromium.org> Reviewed-by: C Shapiro <shapiroc@chromium.org> Reviewed-by: Evan Hernandez <evanhernandez@chromium.org> [modify] https://crrev.com/89a6cafe165c2c49e8c7b5f11ca4e747066ae703/chromeos-config/cros_config_host/cros_config_schema.py [modify] https://crrev.com/89a6cafe165c2c49e8c7b5f11ca4e747066ae703/chromeos-config/cros_config_host/cros_config_test_schema.py [modify] https://crrev.com/89a6cafe165c2c49e8c7b5f11ca4e747066ae703/chromeos-config/cros_config_host/cros_config_schema_unittest.py [modify] https://crrev.com/89a6cafe165c2c49e8c7b5f11ca4e747066ae703/chromeos-config/cros_config_host/cros_config_test_schema_unittest.py [modify] https://crrev.com/89a6cafe165c2c49e8c7b5f11ca4e747066ae703/chromeos-config/cros_config_host/libcros_schema.py
,
Nov 10
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 26