New issue
Advanced search Search tips

Issue 897752 link

Starred by 10 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

SVG Text Selection Regression

Reported by l...@idrsolutions.com, Oct 22

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Example URL:
https://files.idrsolutions.com/chrome-70-svg-text-selection/1.svg

Steps to reproduce the problem:
1. Open SVG page with text
2. Select text across multiple rows

What is the expected behavior?
Standard text selection behavior (e.g. see Firefox)

What went wrong?
The text highlight bounds are not correct - see attached gif.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? Yes Chrome 69

Does this work in other browsers? Yes

Chrome version: 70.0.3538.67  Channel: stable
OS Version: 10.0
Flash Version: 

If you copy and paste the text out, the pasted text is what you would expect if the selection was working normally.

In other words the pasted text contains the full rows of text, not just the text that with the highlighted appearance.

I believe this shows the text selection is working normally,  however the bounds that are highlighted are incorrect.
 
chrome-70-svg-text-selection.gif
183 KB View Download
Bisect info: 585335 (good) - 585346 (bad)
https://chromium.googlesource.com/chromium/src/+log/49e1f815..2abbe360?pretty=fuller
Suspecting r585346 = 2abbe3603ada136a91b04abc6d0c4e93e90e98f9 = https://crrev.com/c/1183011 by yoichio@chromium.org
"Skip invalidation rect update if empty"
Landed in 70.0.3531.0
Labels: Needs-Triage-M70 Needs-Bisect
Cc: phanindra.mandapaka@chromium.org
Labels: -Needs-Bisect ReleaseBlock-Stable Triaged-ET RegressedIn-70 Target-70 Target-71 Target-72 M-70 FoundIn-71 FoundIn-70 FoundIn-72 hasbisect OS-Linux OS-Mac
Owner: yoichio@chromium.org
Status: Assigned (was: Unconfirmed)
As per comment #0 and comment #1, able to reproduce issue on reported chrome version 70.0.3538.67 & on latest chrome 72.0.3587.0 using Windows 10, Ubuntu 14.04 and Mac 10.13.6. As per comment #1 providing bisect information below.

Bisect Info:
================
Good build: 70.0.3530.0
Bad build: 70.0.3531.0

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/49e1f815..2abbe360?pretty=fuller

suspect: https://chromium.googlesource.com/chromium/src/+/954ed9ceb26067a267165e440bd863f74820ddef

Reviewed-on: https://chromium-review.googlesource.com/1183011

@Yoichi Osato: Please confirm the issue and help in re-assigning if it is not related to your change.Adding 'ReleaseBlock-Stable' label for M-70. Please feel free to remove if this is not applicable.

Thanks..!
Cc: -phanindra.mandapaka@chromium.org
Owner: phanindra.mandapaka@chromium.org
M70 was already shipped. Which stable is this issue blocking?
Labels: -Target-70 -M-70 M-71
We can punt this to M71.
Labels: -Type-Bug -Pri-2 Pri-1 Type-Bug-Regression
Owner: yoichio@chromium.org
Marking as P1 stable release-blocking regression targeted at M71.
Components: -Blink Blink>Paint>Invalidation
Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable  ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable  ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
Labels: -ReleaseBlock-Stable -Target-71
This issue is still high prioritized but not a stable blocker.
Status: Started (was: Assigned)
We would appreciate a speedy resolution. We provide a solution that relies on SVG to display documents in the browser. As you might imagine, this issue has a significant impact for us and makes us look bad.
This issue will be fixed at M72.
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2576522f4c3b1ece705959ba065ce4b98ba4961e

commit 2576522f4c3b1ece705959ba065ce4b98ba4961e
Author: Yoichi Osato <yoichio@chromium.org>
Date: Thu Nov 08 09:04:01 2018

Invalidate LayoutSVGText when descendant LayoutText is invalidated.

We used to invalidate always LayoutSVGText even local selection rect
was empty before inserting early return of L342.
That caused regression that selection in svg text is not invalidated.

This patch fixes the regression by invalidating LayoutSVGText always
as before.

Bug:  897752 
Change-Id: I534959ccb461d55d38e85e053c9b9c478b3878b3
Reviewed-on: https://chromium-review.googlesource.com/c/1314019
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606388}
[add] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/svg/text-selection-update-expected.txt
[add] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/WebKit/LayoutTests/paint/invalidation/svg/text-selection-update.svg
[add] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/text-selection-update-expected.png
[add] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/text-selection-update-expected.txt
[add] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/text-selection-update-expected.png
[add] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/text-selection-update-expected.txt
[add] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/text-selection-update-expected.png
[add] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/text-selection-update-expected.txt
[modify] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/blink/renderer/core/paint/object_paint_invalidator.cc

Status: Fixed (was: Started)
Cc: susan.boorgula@chromium.org
 Issue 904543  has been merged into this issue.
Is it possible for this fix to be merged into 71?
Unless a issue is a huge disaster or a security issue to be fixed ASAP, we don't.
Thanks for the information.

I understand that SVG text selection is not a widely used feature, but those that rely on it would consider this issue a huge disaster (it is the same impact as breaking the selection of HTML text).

Can I kindly request you consider merging the fix into 71?

Thanks
Labels: Merge-Request-71
O.K. Added the merge request tag. Release sheriffs will capture this.
Project Member

Comment 22 by sheriffbot@chromium.org, Nov 21

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Rejected-71
As this is regressed in M70, M71 is very close to stable promotion and patch is not fully safe to merge per offline chat with  yoichio@, rejecting merge to M71.

At this stage we're ONLY taking absolutely critical and safe merges in. 
Thank you for trying.
 Issue 915732  has been merged into this issue.
 Issue 920584  has been merged into this issue.
Cc: swarnasree.mukkala@chromium.org
 Issue 923419  has been merged into this issue.

Sign in to add a comment