SVG Text Selection Regression
Reported by
l...@idrsolutions.com,
Oct 22
|
|||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0 Example URL: https://files.idrsolutions.com/chrome-70-svg-text-selection/1.svg Steps to reproduce the problem: 1. Open SVG page with text 2. Select text across multiple rows What is the expected behavior? Standard text selection behavior (e.g. see Firefox) What went wrong? The text highlight bounds are not correct - see attached gif. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes Chrome 69 Does this work in other browsers? Yes Chrome version: 70.0.3538.67 Channel: stable OS Version: 10.0 Flash Version: If you copy and paste the text out, the pasted text is what you would expect if the selection was working normally. In other words the pasted text contains the full rows of text, not just the text that with the highlighted appearance. I believe this shows the text selection is working normally, however the bounds that are highlighted are incorrect.
,
Oct 22
,
Oct 23
As per comment #0 and comment #1, able to reproduce issue on reported chrome version 70.0.3538.67 & on latest chrome 72.0.3587.0 using Windows 10, Ubuntu 14.04 and Mac 10.13.6. As per comment #1 providing bisect information below. Bisect Info: ================ Good build: 70.0.3530.0 Bad build: 70.0.3531.0 CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/49e1f815..2abbe360?pretty=fuller suspect: https://chromium.googlesource.com/chromium/src/+/954ed9ceb26067a267165e440bd863f74820ddef Reviewed-on: https://chromium-review.googlesource.com/1183011 @Yoichi Osato: Please confirm the issue and help in re-assigning if it is not related to your change.Adding 'ReleaseBlock-Stable' label for M-70. Please feel free to remove if this is not applicable. Thanks..!
,
Oct 24
M70 was already shipped. Which stable is this issue blocking?
,
Oct 24
We can punt this to M71.
,
Oct 25
Marking as P1 stable release-blocking regression targeted at M71.
,
Oct 25
,
Oct 29
Adding release blocker label for this issue.Please reduce priority or remove if not the case. Thank You!
,
Oct 29
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Oct 29
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Nov 1
This issue is still high prioritized but not a stable blocker.
,
Nov 2
,
Nov 7
We would appreciate a speedy resolution. We provide a solution that relies on SVG to display documents in the browser. As you might imagine, this issue has a significant impact for us and makes us look bad.
,
Nov 8
This issue will be fixed at M72.
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2576522f4c3b1ece705959ba065ce4b98ba4961e commit 2576522f4c3b1ece705959ba065ce4b98ba4961e Author: Yoichi Osato <yoichio@chromium.org> Date: Thu Nov 08 09:04:01 2018 Invalidate LayoutSVGText when descendant LayoutText is invalidated. We used to invalidate always LayoutSVGText even local selection rect was empty before inserting early return of L342. That caused regression that selection in svg text is not invalidated. This patch fixes the regression by invalidating LayoutSVGText always as before. Bug: 897752 Change-Id: I534959ccb461d55d38e85e053c9b9c478b3878b3 Reviewed-on: https://chromium-review.googlesource.com/c/1314019 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606388} [add] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/svg/text-selection-update-expected.txt [add] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/WebKit/LayoutTests/paint/invalidation/svg/text-selection-update.svg [add] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/text-selection-update-expected.png [add] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/text-selection-update-expected.txt [add] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/text-selection-update-expected.png [add] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/text-selection-update-expected.txt [add] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/text-selection-update-expected.png [add] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/text-selection-update-expected.txt [modify] https://crrev.com/2576522f4c3b1ece705959ba065ce4b98ba4961e/third_party/blink/renderer/core/paint/object_paint_invalidator.cc
,
Nov 9
,
Nov 13
,
Nov 19
Is it possible for this fix to be merged into 71?
,
Nov 20
Unless a issue is a huge disaster or a security issue to be fixed ASAP, we don't.
,
Nov 20
Thanks for the information. I understand that SVG text selection is not a widely used feature, but those that rely on it would consider this issue a huge disaster (it is the same impact as breaking the selection of HTML text). Can I kindly request you consider merging the fix into 71? Thanks
,
Nov 21
O.K. Added the merge request tag. Release sheriffs will capture this.
,
Nov 21
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 21
As this is regressed in M70, M71 is very close to stable promotion and patch is not fully safe to merge per offline chat with yoichio@, rejecting merge to M71. At this stage we're ONLY taking absolutely critical and safe merges in.
,
Nov 21
Thank you for trying.
,
Dec 17
Issue 915732 has been merged into this issue.
,
Jan 10
Issue 920584 has been merged into this issue.
,
Jan 21
(2 days ago)
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by woxxom@gmail.com
, Oct 22