Check if spinlock_linux-inl.h could use futex unconditionally |
||
Issue descriptionhttps://cs.chromium.org/chromium/src/third_party/tcmalloc/chromium/src/base/spinlock_linux-inl.h?q=futex_private_flag+&dr=CSs&l=43 currently has a static initializer to check if syscall(__NR_futex) works. That syscall has been around since linux 2.6.0 (2003) and the absl version doesn't have this check from what I can tell (https://cs.chromium.org/chromium/src/third_party/abseil-cpp/absl/synchronization/internal/waiter.cc?type=cs&q=futex_private_flag+&g=0&l=63) We also use futex_private_flag which was added in 2.6.22 (jul 2007). absl uses that unconditionally as well. I'm guessing we can just remove that check and assume it succeeds. +linux folks to confirm/deny :-)
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e7fc52e8f3a0eee4568e1a553c2b6bee3748c3e commit 5e7fc52e8f3a0eee4568e1a553c2b6bee3748c3e Author: Nico Weber <thakis@chromium.org> Date: Mon Oct 22 15:40:56 2018 linux, android: Always assume futex syscall is availabble. Bug: 897742 Change-Id: Id980269ea623f9800b62aead3896d107690a64eb Reviewed-on: https://chromium-review.googlesource.com/c/1293559 Reviewed-by: Primiano Tucci <primiano@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601583} [modify] https://crrev.com/5e7fc52e8f3a0eee4568e1a553c2b6bee3748c3e/third_party/tcmalloc/README.chromium [modify] https://crrev.com/5e7fc52e8f3a0eee4568e1a553c2b6bee3748c3e/third_party/tcmalloc/chromium/src/base/spinlock_linux-inl.h [modify] https://crrev.com/5e7fc52e8f3a0eee4568e1a553c2b6bee3748c3e/third_party/tcmalloc/gperftools-2.0/chromium/src/base/spinlock_linux-inl.h
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/211f614f196da95723f115921c631d274a064657 commit 211f614f196da95723f115921c631d274a064657 Author: Nico Weber <thakis@chromium.org> Date: Mon Oct 22 16:21:01 2018 linux: Lower static initializer expectations by 1, to 5. https://chromium-review.googlesource.com/c/1293559 removed another SI. TBR=dpranke Bug: 897742 ,94925 Change-Id: I24dccd770fcba4f06bd85c6da7678adc95b40601 Reviewed-on: https://chromium-review.googlesource.com/c/1293795 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601606} [modify] https://crrev.com/211f614f196da95723f115921c631d274a064657/infra/scripts/legacy/scripts/slave/chromium/sizes.py
,
Oct 22
|
||
►
Sign in to add a comment |
||
Comment 1 by thakis@chromium.org
, Oct 22