New issue
Advanced search Search tips

Issue 897724 link

Starred by 1 user
Status: Fixed
Owner:
backer@chromium.org
Closed: Oct 31
Cc:
penghuang@chromium.org
vmi...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 898270



Sign in to add a comment

Make it possible to use GLES2Impl concurrently with RasterImplGLES

Project Member Reported by backer@chromium.org, Oct 22 
Migrating clients over to RImplGLES from GLESImpl would be easier if we could do it piecemeal (one subsystem at a time). This is conceptually simple because RImplGLES is a wrapper around a GLESImpl. However, one problem with that is that RImplGLES has a bit of internal state. This state would be invalidated if on part of the code uses GLESImpl in a way that RImplGLES is not tracking.

This bug is to see if we can remove the internal state from RImplGLES enough that it is safe to use concurrently with the GLES2Impl that it wraps.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef2f5c559dc2736e33758dde9bc430f2b78f1d81

commit ef2f5c559dc2736e33758dde9bc430f2b78f1d81
Author: Jonathan Backer <backer@chromium.org>
Date: Wed Oct 24 14:06:15 2018

Read texture binding from GLES2Impl

One of the hazards of using the ContextGL and RasterInterface from
RasterContextProvider is that the texture bindings could become
inconsistent between the 2. This CL makes RasterImplementationGLES2
check the bindings in GLES2Implementation, which should help reduce
inconsistencies.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I84394fe279cca0f02c6d41c9f5b5a3319772f33b
Bug:  897724 
Reviewed-on: https://chromium-review.googlesource.com/c/1289513
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602326}
[modify] https://crrev.com/ef2f5c559dc2736e33758dde9bc430f2b78f1d81/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/ef2f5c559dc2736e33758dde9bc430f2b78f1d81/gpu/command_buffer/client/gles2_implementation.h
[modify] https://crrev.com/ef2f5c559dc2736e33758dde9bc430f2b78f1d81/gpu/command_buffer/client/raster_implementation_gles.cc
[modify] https://crrev.com/ef2f5c559dc2736e33758dde9bc430f2b78f1d81/gpu/command_buffer/client/raster_implementation_gles.h

Comment 2 by rjkroege@chromium.org, Oct 24

Blocking: 898270
Labels: vulkanize

Comment 3 by rjkroege@chromium.org, Oct 29

Labels: -vulkanize Proj-Vulkanize

Comment 4 by backer@chromium.org, Oct 31

Status: Fixed (was: Started)
If we want to do more here, we can reopen this.
►

Sign in to add a comment