network_service_browser_tests failing on chromium.mac/Mac10.12 Tests |
|||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of yigu@chromium.org network_service_browser_tests failing on chromium.mac/Mac10.12 Tests Builders failed on: - Mac10.12 Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b45d94c72d3369443534201f44814865e4bbb77 commit 2b45d94c72d3369443534201f44814865e4bbb77 Author: Yi Gu <yigu@chromium.org> Date: Mon Oct 22 14:13:16 2018 Disable HostedAppTest.DesktopPWAsFlagDisabledCreatedForInstalledPwa on Mac Test failures were introduced by a WPT patch https://chromium-review.googlesource.com/c/chromium/src/+/1293038 TBR=robertma@chromium.org NOTRY=true Bug: 897719 Change-Id: I10f67a682e8747e745bf12c180356f5ec1674b01 Reviewed-on: https://chromium-review.googlesource.com/c/1292803 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601560} [modify] https://crrev.com/2b45d94c72d3369443534201f44814865e4bbb77/chrome/browser/ui/extensions/hosted_app_browsertest.cc
,
Oct 22
,
Oct 22
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81e332715ae27062b6f3b97bfa124ca7a8544982 commit 81e332715ae27062b6f3b97bfa124ca7a8544982 Author: Matt Giuca <mgiuca@chromium.org> Date: Fri Nov 30 06:00:17 2018 Revert "Disable HostedAppTest.DesktopPWAsFlagDisabledCreatedForInstalledPwa on Mac" This reverts commit 2b45d94c72d3369443534201f44814865e4bbb77. Reason for revert: WPT patch can't be responsible for regressing this test. Since this is >1M old, we have no data to investigate (may be bot flake), so re-enabling the test and if it's still a problem, we'll have more data. Original change's description: > Disable HostedAppTest.DesktopPWAsFlagDisabledCreatedForInstalledPwa on Mac > > Test failures were introduced by a WPT patch > https://chromium-review.googlesource.com/c/chromium/src/+/1293038 > > TBR=robertma@chromium.org > NOTRY=true > > Bug: 897719 > Change-Id: I10f67a682e8747e745bf12c180356f5ec1674b01 > Reviewed-on: https://chromium-review.googlesource.com/c/1292803 > Reviewed-by: Yi Gu <yigu@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601560} Bug: 897719 Change-Id: Ieb3f4a3959faeb46e9c6378d5721e18dba5b2ef9 Reviewed-on: https://chromium-review.googlesource.com/c/1356173 Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#612580} [modify] https://crrev.com/81e332715ae27062b6f3b97bfa124ca7a8544982/chrome/browser/ui/extensions/hosted_app_browsertest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by yigu@chromium.org
, Oct 22Status: Assigned (was: Available)