shend@, I assume a result of the recent "hide when shelf is clicked" behavior.  In this edge case, I suppose we should not hide it.

Doh! Of course.

Actually, Paul, shouldn't we be hiding the virtual keyboard in this case? The keyboard icon is highlighted, so I would expect that clicking it would close the virtual keyboard?

Oh, I misunderstood.  Currently, that button does nothing if the keyboard is showing.  If the keyboard is hidden, it causes it to display.

Could we do this:
* If the keyboard is already showing, hide when the shelf is clicked (new behavior).  When clicking this specific button, treat it as a hide (not as a click-after-hide==show).
* If the keyboard is hidden, clicking the button should show the keyboard.

Sounds good. Basically, the button should always toggle the virtual keyboard.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3e3afec9434a3c33160d2f65a50389134c965b3

commit d3e3afec9434a3c33160d2f65a50389134c965b3
Author: Darren Shen <shend@chromium.org>
Date: Thu Oct 25 22:47:02 2018

[VK] Keyboard tray icon should toggle the virtual keyboard.

We're changing the keyboard tray action to toggle the virtual keyboard
instead of always showing the virtual keyboard.

Previously, we made it so that the VK hides when you interact with
the shelf. So we also have to exclude the keyboard tray icon from this
behaviour.

Bug:  897672 
Change-Id: I019f8acf2263a18a3f9248f232e51156c0b8a349
Reviewed-on: https://chromium-review.googlesource.com/c/1298513
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602909}
[modify] https://crrev.com/d3e3afec9434a3c33160d2f65a50389134c965b3/ash/BUILD.gn
[modify] https://crrev.com/d3e3afec9434a3c33160d2f65a50389134c965b3/ash/system/status_area_widget.cc
[modify] https://crrev.com/d3e3afec9434a3c33160d2f65a50389134c965b3/ash/system/status_area_widget_unittest.cc
[modify] https://crrev.com/d3e3afec9434a3c33160d2f65a50389134c965b3/ash/system/virtual_keyboard/virtual_keyboard_tray.cc
[add] https://crrev.com/d3e3afec9434a3c33160d2f65a50389134c965b3/ash/system/virtual_keyboard/virtual_keyboard_tray_unittest.cc
[modify] https://crrev.com/d3e3afec9434a3c33160d2f65a50389134c965b3/testing/buildbot/filters/chromeos.single_process_mash.ash_unittests.filter

Requesting M71 merge for c#6, thanks!

Hi, has this been verified?  What's the risk if we merge?  Not seeing that on the bug.. Thanks.

This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

There are some unit tests to verify. I would say this is low risk. Paul, WYDT?

shend@ defer to your judgement re: risk, which sounds minimal.

As far as user experience, this fixes a bug with some behavior we changed in M71, so having the changed behavior work correctly from its introduction is valuable to avoid confusing users.  

Did anyone test on ToT or M72?

How did testing go on this?

Verified on ToT.

Merge approved for ChromeOS M71

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/5c084142082e2fa8c6133e118d1a8faad63a21d9

Commit: 5c084142082e2fa8c6133e118d1a8faad63a21d9
Author: shend@chromium.org
Commiter: shend@chromium.org
Date: 2018-11-06 22:34:36 +0000 UTC

[Merge M71] Keyboard tray icon should toggle the virtual keyboard.

Cherry picked from d3e3afec9434a3c33160d2f65a50389134c965b3.

We're changing the keyboard tray action to toggle the virtual keyboard
instead of always showing the virtual keyboard.

Previously, we made it so that the VK hides when you interact with
the shelf. So we also have to exclude the keyboard tray icon from this
behaviour.

Bug:  897672 
Change-Id: Ic7904cae09acb5ff5792ab120f3eb77f1df74e09
Reviewed-on: https://chromium-review.googlesource.com/c/1321369
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#549}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c084142082e2fa8c6133e118d1a8faad63a21d9

commit 5c084142082e2fa8c6133e118d1a8faad63a21d9
Author: Darren Shen <shend@chromium.org>
Date: Tue Nov 06 22:34:36 2018

[Merge M71] Keyboard tray icon should toggle the virtual keyboard.

Cherry picked from d3e3afec9434a3c33160d2f65a50389134c965b3.

We're changing the keyboard tray action to toggle the virtual keyboard
instead of always showing the virtual keyboard.

Previously, we made it so that the VK hides when you interact with
the shelf. So we also have to exclude the keyboard tray icon from this
behaviour.

Bug:  897672 
Change-Id: Ic7904cae09acb5ff5792ab120f3eb77f1df74e09
Reviewed-on: https://chromium-review.googlesource.com/c/1321369
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#549}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/5c084142082e2fa8c6133e118d1a8faad63a21d9/ash/system/status_area_widget.cc
[modify] https://crrev.com/5c084142082e2fa8c6133e118d1a8faad63a21d9/ash/system/virtual_keyboard/virtual_keyboard_tray.cc