New issue
Advanced search Search tips

Issue 897655 link

Starred by 3 users
Status: Fixed
Owner:
yhanada@chromium.org
Closed: Oct 26
Cc:
yusukes@chromium.org
shend@chromium.org
osh...@chromium.org
steve...@chromium.org
yhanada@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Keyboard type is set to PHYSICAL while Android IME is used.

Project Member Reported by yhanada@chromium.org, Oct 22 
crrev.com/c/1285329 changes exo::Keyboard to use OnKeyboardEnabledChanged() and crrev.com/c/1291350 makes ArcInputMethodManagerService use kAndroidDisabled enable flags.

These CLs change the passed value to OnKeyboardTypChanged in components/exo/keyboard.cc when Android IME is used.
Before these CLs, ArcInputMethodManagerService uses SetKeyboardShowOverride(). It doesn't change return value of keyboard::IsKeyboardEnabled(), but stop KeyboardController showing Chrome OS VK.

Comment 1 by yhanada@chromium.org, Oct 22 

I'm going to upload a workaround CL to fix it for now. For longer term, I can implement KeyboardUI interface for Android IMEs and then we will be able to remove kAndroidDisabled enable flag.

Comment 2 by steve...@chromium.org, Oct 22 

I'm not sure I full understand the problem, but I apologize for breaking this. Thanks for the workaround. I am definitely in favor of eliminating kAndroidDisabled.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5ce12d95631c3e62039479c332e6fdf745eb421

commit a5ce12d95631c3e62039479c332e6fdf745eb421
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Tue Oct 23 04:48:45 2018

Fix keyboard type when Android IME is used.

After crrev.com/c/1291350, OnKeyboardEnabledChanged is called with false
when Android IME is used.
This CL is a workaround for it. For longer term solution, please see
the linked bug.

Bug:  897655 
Test: Gboard shows up in tablet mode.
Change-Id: I1047716212f1a4ec782b108fe02cdbef29aa2c6d
Reviewed-on: https://chromium-review.googlesource.com/c/1293106
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601851}
[modify] https://crrev.com/a5ce12d95631c3e62039479c332e6fdf745eb421/components/exo/keyboard.cc

Comment 4 by steve...@chromium.org, Oct 24

Owner: yhanada@chromium.org
Status: Assigned (was: Untriaged)
Can you add steps to test this here?

I have some additional changes that I would like to test with an Android keyboard.

Comment 5 by yhanada@chromium.org, Oct 25 

Repro steps are:
1. enable arc-input-method flag from chrome://flags
2. Install Gboard app or some other IMEs from PlayStore
3. Put the device in tablet mode.
4. Enable the installed IME from chrome://settings
5. focus on any text field on Android app or the browser.

Note that the feature is implemented only on P. so you need nocturne or eve with recent canary.

Comment 6 by yhanada@chromium.org, Oct 26

Status: Fixed (was: Assigned)
Confirmed the fix doesn't need to be merged to M-71. Let me close this bug now.
►

Sign in to add a comment