New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 897653 link

Starred by 1 user
Status: Started
Owner:
█ yoshiki@chromium.org
Last visit > 30 days ago
Cc:
yamaguchi@chromium.org
tetsui@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Inline buttons are not visible behind arc notifications

Project Member Reported by yoshiki@chromium.org, Oct 22 
Chrome Version: (copy from chrome://version)
OS: (e.g. Win10, MacOS 10.12, etc...)

What steps will reproduce the problem?
(1) Show an ARC notification
(2) Swipe it

What is the expected result?
The inline buttons should be visible

What happens instead?
No inline buttons are visible


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e12fcfe093c58aa7519aa416d9a77cb4f66b311c

commit e12fcfe093c58aa7519aa416d9a77cb4f66b311c
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Wed Oct 24 11:53:57 2018

Close swipe controls after the button click is processed.

Previously, the swipe controls are closed before the button click
is processed. This CL moves the code to close them after the button
click handlers.

Also this CL removes the unnecessary CloseSwipeControl(s), because
we had some redundant calls.

Bug: 897653
Test: manual
Change-Id: I2dd728c7e2069278c5f7a09ea66c79e31e28ab59
Reviewed-on: https://chromium-review.googlesource.com/c/1295756
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602305}
[modify] https://crrev.com/e12fcfe093c58aa7519aa416d9a77cb4f66b311c/ash/system/message_center/arc/arc_notification_view.cc
[modify] https://crrev.com/e12fcfe093c58aa7519aa416d9a77cb4f66b311c/ash/system/message_center/notification_swipe_control_view.cc
[modify] https://crrev.com/e12fcfe093c58aa7519aa416d9a77cb4f66b311c/ui/message_center/views/message_view.cc
[modify] https://crrev.com/e12fcfe093c58aa7519aa416d9a77cb4f66b311c/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/e12fcfe093c58aa7519aa416d9a77cb4f66b311c/ui/message_center/views/slide_out_controller.h
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/274fb3611e6979a78f16ccd5beceb25c7c73e831

commit 274fb3611e6979a78f16ccd5beceb25c7c73e831
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Thu Oct 25 03:12:59 2018

Get the inline buttons visible behind ARC notificaitons

The inline buttons were not visible for ARC notifications wrongly. This
CL fixes the issue and makes it visible behind ARC notifications
correctly.

Bug: 897653
Test: manual
Change-Id: I052b3e86a10fdc806a40ea2b3df2185eefe35ef4
Reviewed-on: https://chromium-review.googlesource.com/c/1293257
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602596}
[modify] https://crrev.com/274fb3611e6979a78f16ccd5beceb25c7c73e831/ash/system/message_center/arc/arc_notification_view.cc
[modify] https://crrev.com/274fb3611e6979a78f16ccd5beceb25c7c73e831/ash/system/message_center/notification_swipe_control_view.cc
[modify] https://crrev.com/274fb3611e6979a78f16ccd5beceb25c7c73e831/ui/message_center/views/message_view.cc
[modify] https://crrev.com/274fb3611e6979a78f16ccd5beceb25c7c73e831/ui/message_center/views/message_view.h
[modify] https://crrev.com/274fb3611e6979a78f16ccd5beceb25c7c73e831/ui/message_center/views/slide_out_controller.cc
[modify] https://crrev.com/274fb3611e6979a78f16ccd5beceb25c7c73e831/ui/message_center/views/slide_out_controller.h
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e545ff9bb71a243a12ff86d03865b5389338838

commit 1e545ff9bb71a243a12ff86d03865b5389338838
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Fri Oct 26 06:15:38 2018

Pass the status of sliding (sliding or not) to OnSlideChanged

This CL passes the status of sliding on OnSlideChanged handler so that
the handler in ArcNotificationContentView can hide the copied surface
at the timing of the sliding finished.

Bug: 897653
Test: manual
Change-Id: I8e76d54f59105b6101b1d2dfc10eb171272be611
Reviewed-on: https://chromium-review.googlesource.com/c/1295632
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603003}
[modify] https://crrev.com/1e545ff9bb71a243a12ff86d03865b5389338838/ash/app_menu/notification_menu_controller.cc
[modify] https://crrev.com/1e545ff9bb71a243a12ff86d03865b5389338838/ash/app_menu/notification_menu_controller.h
[modify] https://crrev.com/1e545ff9bb71a243a12ff86d03865b5389338838/ash/app_menu/notification_menu_view_unittest.cc
[modify] https://crrev.com/1e545ff9bb71a243a12ff86d03865b5389338838/ash/system/message_center/arc/arc_notification_content_view.cc
[modify] https://crrev.com/1e545ff9bb71a243a12ff86d03865b5389338838/ash/system/message_center/arc/arc_notification_content_view.h
[modify] https://crrev.com/1e545ff9bb71a243a12ff86d03865b5389338838/ash/system/message_center/arc/arc_notification_view.cc
[modify] https://crrev.com/1e545ff9bb71a243a12ff86d03865b5389338838/ash/system/message_center/arc/arc_notification_view.h
[modify] https://crrev.com/1e545ff9bb71a243a12ff86d03865b5389338838/ui/message_center/views/message_view.cc
[modify] https://crrev.com/1e545ff9bb71a243a12ff86d03865b5389338838/ui/message_center/views/message_view.h
[modify] https://crrev.com/1e545ff9bb71a243a12ff86d03865b5389338838/ui/message_center/views/slide_out_controller.cc
[modify] https://crrev.com/1e545ff9bb71a243a12ff86d03865b5389338838/ui/message_center/views/slide_out_controller.h
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa6d68be71982d854a6188aec35658c66e45dfbb

commit fa6d68be71982d854a6188aec35658c66e45dfbb
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Wed Oct 31 09:58:54 2018

Test for SlideOutController

This is a follow up of crrev.com/c/1303322. This CL adds a test for it.

Bug: 897653
Test: passed the added test
Change-Id: I546979f9e88c548201c733b446aa6c2f4ab2a7c9
Reviewed-on: https://chromium-review.googlesource.com/c/1308252
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604191}
[modify] https://crrev.com/fa6d68be71982d854a6188aec35658c66e45dfbb/ui/message_center/BUILD.gn
[add] https://crrev.com/fa6d68be71982d854a6188aec35658c66e45dfbb/ui/message_center/views/slide_out_controller_unittest.cc
►

Sign in to add a comment